ansible: Update centos8-vagrant playbook to work for CentOS8.4

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #1831 from tchaikov/wip-build-deb-mem

scripts/build_utils: increase mem per job to 3000 MiB

Merge pull request #1832 from tchaikov/wip-no-master-on-bionic

ceph-dev-cron: remove leap15 from comment for job building master

ceph-dev-cron: remove leap15 from comment for job building master

as we don't build master on leap15 anymore

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

ceph-dev-cron: do not build master on bionic

see also 2cbeb00308051188337773b587ea5e2913a42b56

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

scripts/build_utils: increase mem per job to 3000 MiB

see also https://github.com/ceph/ceph/pull/41677

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1830 from tchaikov/wip-no-bionic-on-master

ceph-dev-*-trigger: stop building master on bionic

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: David Galloway <dgallowa@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

ceph-dev-trigger: remove leap15 from comment for job building master

as we don't build master on leap15 anymore

Signed-off-by: Kefu Chai <kchai@redhat.com>

scripts/build_utils: always pass -DALLOCATOR

this change reverts 901fe2e097548707350bc89c7650e0f72c45d994 and
17b40974b1cb10d1d8ba0373dbf578fb0e82f036.

since we don't need to buld master (quincy and up) on bionic anymore,
there is no need to worry about the FTBFS when compiling with a buggy
gperftools (<2.6.2) shipped along with bionic.

Signed-off-by: Kefu Chai <kchai@redhat.com>

ceph-dev-*-trigger: stop building master on bionic

in short, we don't need to test on bionic anymore for couple reasons:

- for accessing newer GCC
- for accessing more packages

see the discussion at
https://lists.ceph.io/hyperkitty/list/dev@ceph.io/thread/BW5NKQ4KTOPV7OYUBUHVDVCSH72LVIEO/

the only qa suite referencing ubuntu 18.04 is the qa/suites/orch/rook/smoke,
but it deploys ceph using Rook, and the container image of Ceph is
based on CentOS, so stop building on ubuntu/bionic does not
break it, despite the fact that 18.04 is included by
qa/suites/orch/rook/smoke/0-distro.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1829 from tchaikov/wip-viva-la-venv

*/build/teardown: create venv for running teardown_vagrant_tests()

ceph-volume-nightly: do not set $scenarios

teardown_vagrant_tests() takes care of this already.

Signed-off-by: Kefu Chai <kchai@redhat.com>

*/build/teardown: create venv for running teardown_vagrant_tests()

to address the regression introduced by
e302eaabb977f3e93b1a7005c879f4b2eba581fc, which failed to create venv
after removing the global `$(mktemp -td venv.XXXXXXXXXX)` call.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1826 from dmick/wip-ceph-grafana

Add ceph-grafana job

Add ceph-grafana job to build ceph-grafana container.

This job builds from the ceph workspace based on a ceph branch and an
architecture (x86_64 or arm64).  A parent job calls this job for
branches or architectures.  More versions etc. could be parameterized,
but for now they're hardcoded in the ceph branch in
monitoring/grafana/build/Makefile.

Merge pull request #1825 from ceph/wip-kernel-sha

kernel: Export sha1 as an env variable so shaman build URLs work

kernel: Export sha1 as an env variable so shaman build URLs work

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #1824 from ceph/wip-oklist

ceph-website: Allow Pete-Robelou to build beta.ceph.io

ceph-website: Allow Pete-Robelou to build beta.ceph.io

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #1821 from tchaikov/wip-teuthology-pull-requests

teuthology-pull-requests: call create_venv_dir()

teuthology-pull-requests: call create_venv_dir()

it was an oversight in e302eaabb977f3e93b1a7005c879f4b2eba581fc

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1820 from ceph/create_venv_ca_syntax_check

ceph-ansible-syntax: create virtualenv after dir creation

ceph-ansible-syntax: create virtualenv after dir creation

add back venv creation that has been removed accidentally by
commit 3d832da831f0b938faa6f845617b0257bda184f4

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #1819 from ceph/fix_ca_syntax

ceph-ansible-syntax: fix broken job

ceph-ansible-syntax: fix broken job

commit b09f6470745a09ce4fce0265cb7a22a56b049886 supposed to fix
regression introduced by e302eaabb977f3e93b1a7005c879f4b2eba581fc missed
the ceph-ansible-pr-syntax-check job, so the CI is still failing like
following:

```
[ceph-ansible-pr-syntax-check] $ /bin/bash /tmp/jenkins6031146002439656501.sh
+ set -e
+ virtualenv
You must provide a DEST_DIR
Usage: virtualenv [OPTIONS] DEST_DIR
```

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #1818 from tchaikov/wip-ansible

ceph-ansible*: pass $TEMPVENV to start_tox

Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>

ceph-ansible*: pass $TEMPVENV to start_tox

to address the regression introduced by e302eaabb977f3e93b1a7005c879f4b2eba581fc

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #1816 from ceph/wip-kernel-deb-source-name

kernel: specify KDEB_SOURCENAME for make bindeb-pkg

kernel: specify KDEB_SOURCENAME for make bindeb-pkg

Undo the damage caused by linux.git commit 82526ef43399 ("kbuild:
deb-pkg: change the source package name to linux-upstream").

We don't build a source package, but the source package name gets
embedded in the package metadata and ends up affecting the paths in
the repository generated by chacra.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #1815 from tchaikov/wip-venv-dir

*: use create_venv_dir() helper

Reviewed-by: David Galloway <dgallowa@redhat.com>

*: use create_venv_dir() helper

* define create_venv_dir() helper to
  1. create a temp dir
  2. set a trap to clean it up upon exit
* use create_venv_dir() in all scripts where
  TEMPVENV and/or VENV variables are used.

this change can help us to avoid creating a tempdir in /tmp,
and keep the tempdir forever.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1813 from tchaikov/wip-venv-cleanup

scripts/build_utils.sh: pass VENV to helper functions

Reviewed-by: David Galloway <dgallowa@redhat.com>

Merge pull request #1699 from tchaikov/wip-ceph-pr-commits-cleanup

ceph-pr-commits: wrap lines over 79 chars

Merge pull request #1812 from ceph/wip-sunilkumarn417

teuthology-pull-requests: Allowlist sunilkumarn417

Merge pull request #1814 from tchaikov/wip-allocator-tcmalloc

ceph-dev-*-setup: do not specify ALLOCATOR

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

ceph-dev-*-setup: do not specify ALLOCATOR

$DIST env variable is not set by ceph-dev-new-setup, as it prepares
the dist tarball for building on different distros. to build with
tcmalloc if gperftools 2.6.2 is available, we leave it to cmake to
decide the allocator to use. because, if ALLOCATOR is not specified,
cmake first tries to find gperftools, and falls back to JeMalloc, and
the libc allocator. after quincy, the fix for gperftools <2.6.2 is
dropped, and gperftools >= 2.6.2 is required, so it's safe. before
quincy, the fix gperftools <2.6.2 is still included, so it's also safe.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1811 from tchaikov/wip-no-tcmalloc-bionic

ceph-dev-*-setup: use libc allocator when building quincy on bionic

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

ceph-dev-*-setup: use libc allocator when building quincy on bionic

see also https://tracker.ceph.com/issues/39703, to silence the warning
std::allocator<void> is deprecated in C++17 and will be removed in
C++20, so stop using allocator<void> in quincy and up.

but the libtcmalloc shipped by bionic is still buggy (v2.5), so we should not
build qunincy and up with tcmalloc on this distro.

after this change, we only build quincy and up with tcmalloc on non-bionic distro.

Signed-off-by: Kefu Chai <kchai@redhat.com>

scripts/build_utils.sh: pass VENV to helper functions

pass VENV to following functions explicitly:

* teardown_vagrant_tests()
* start_tox()
* build_debs()
* install_python_packages()
* install_python_packages_no_binary()
* pip_download()
* check_binary_existence()

prepare for the cleanup to avoid creating TEMPVENV everytime the script
is included.

Signed-off-by: Kefu Chai <kchai@redhat.com>

scripts/build_utils.sh: reindent start_tox()

for better readability

Signed-off-by: Kefu Chai <kchai@redhat.com>

teuthology-pull-requests: Allowlist sunilkumarn417

https://github.com/ceph/teuthology/pull/1646#issuecomment-841353102

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #1810 from ceph/update_cephadm-ansible

cephadm-ansible: update scripts

cephadm-ansible: update scripts

This updates the build and teardown scripts so the playbook in
cephadm-ansible repository can be tested with the upstream ci.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #1809 from ceph/cephadm-ansible

cephadm-ansible: add initial job

cephadm-ansible: add initial job

This adds a job definition for cephadm-ansible.
For now it doesn't run anything, it's just adding the definition into
jenkins so we can start setting up the corresponding repository
(cephadm-ansible).

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #1807 from mgfritch/opensuse-leap-15.3

ceph-dev-build: update {build,setup}_osc

Reviewed-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1808 from tchaikov/wip-ceph-pr-docs-check

ceph-pr-docs: add annotation to build result

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

ceph-pr-docs: add annotation to build result

* do not "set -e", so the script does not exit immediately. instead
  use a variable of "succeed" to store true if the document is built
  successfully, and false otherwise
* feed the output of the sphinx-build to github-check tool, so it
  is able to parse and call the GitHub Check API to update the
  Check web page on the PR if the test fails.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1684 from tchaikov/wip-cbt-lint

ceph-cbt-lint: add cbt lint test

Reviewed-by: David Galloway <dgallowa@redhat.com>

ceph-dev-build: update {build,setup}_osc

use openSUSE Leap 15.3 repository for pacific and quincy

Fixes: https://tracker.ceph.com/issues/50563
Signed-off-by: Michael Fritch <mfritch@suse.com>

Merge pull request #1777 from ceph/drop_luminous_from_cv_nightly

ceph-volume-nightly: remove luminous

Merge pull request #1806 from ceph/fix_ganesha_builds

nfs-ganesha: fix broken builds

nfs-ganesha: fix broken builds

This job must be updated due to recent chances in nfs-ganesha (CMakeLists.txt)

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #1805 from tchaikov/wip-debug-build-of-crimson

scripts/build_utils.sh: build Debug builds for crimson flavor

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

scripts/build_utils.sh: build Debug builds for crimson flavor

for ease of testing.

Signed-off-by: Kefu Chai <kchai@redhat.com>

scripts/build_utils.sh: use "+=" for appending string to a variable

less repeating this way.

Signed-off-by: Kefu Chai <kchai@redhat.com>

ceph-dev-*setup: extract ceph_build_args_from_flavor() out

so this helper can be shared by ceph-dev-new-setup and ceph-dev-setup
jobs.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1793 from ceph/wip-1772

sync-push: Use sort -V

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1804 from tchaikov/wip-no-ppa-on-bionic

scripts/build_utils.sh: do not use ppa on bionic

Reviewed-by: Casey Bodley <cbodley@redhat.com>

scripts/build_utils.sh: do not use ppa on bionic

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1803 from tchaikov/wip-pr-docs-cleanup

ceph-pr-docs: remove more leftover source.list

ceph-pr-docs: remove more leftover source.list

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1801 from ceph/guits-add-ca-nightly-fs2bs

ceph-ansible: add a nightly job

ceph-ansible: add a nightly job

This adds a missing nightly job 'filestore_to_bluestore'

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #1800 from rzarzynski/wip-crimson-only-builds

ceph-dev-new-trigger: add a crimson-only building variant.

Reviewed-by: Kefu Chai <kchai@redhat.com>

ceph-dev-new-trigger: add a crimson-only building variant.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #1799 from dmick/wip-nfs-ganesha

nfs-ganesha: change patch to sed, drop some older distro/releases

nfs-ganesha: remove centos7 and xenial, build arm64 (centos8 only)

Signed-off-by: Dan Mick <dmick@redhat.com>

nfs-ganesha: fix patch for debian/rules

Some branches of nfs-ganesha-debian don't have the right format for
the patch file to work (Cmake features can be turned on or off
with various words, ON/OFF, YES/NO, etc.).  Use sed instead to be
more resilient to such chicanery.

Signed-off-by: Dan Mick <dmick@redhat.com>

Merge pull request #1797 from dmick/wip-build-utils

Wrong variable use / shell syntax errors in build_utils.sh

Reviewed-by: Kefu Chai <kchai@redhat.com>

build_utils.sh: delete unescaped newlines in sources.list addition

Signed-off-by: Dan Mick <dmick@redhat.com>

build_utils.sh: check correct version of variable for distro

Signed-off-by: Dan Mick <dmick@redhat.com>

Merge pull request #1796 from ceph/wip-unattende

ansible: Remove unattended-upgrades after package install

ansible: Remove unattended-upgrades after package install

One of the packages we *do* want to install (software-properties-common maybe) pulls in unattended upgrades.  It's not a strict dependency so we can remove it after package install.  It's the only package that gets removed.

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #1795 from tchaikov/wip-hookdir

scripts/build_utils.sh: set hookdir using pbuilderrc

Reviewed-by: David Galloway <dgallowa@redhat.com>

scripts/build_utils.sh: set hookdir using pbuilderrc

per our testing, --hookdir does not work even the pbuilderrc(5) puts

> HOOKDIR=/usr/lib/pbuilder/hooks
>    Specifies the default location for the user hooks directory.  This is overridden with the option --hookdir.

so let use HOOKDIR as we did before e81fd7baa0e49242cef2db66eeb3fe6dc4269905

Signed-off-by: Kefu Chai <kchai@redhat.com>

scripts/build_utils.sh: no need to update repo if ppa repo is not used

Signed-off-by: Kefu Chai <kchai@redhat.com>

scripts/build_utils.sh: make user script executable

as per pbuilder(8),

> The  scripts  must be executable and may be either binaries or
> interpreted scripts.

Signed-off-by: Kefu Chai <kchai@redhat.com>

sync-push: Use sort -V

Signed-off-by: David Galloway <dgallowa@redhat.com>

Merge pull request #1792 from tchaikov/wip-updates

scripts/build_utils.sh: install gnupg before ppa packages

scripts/build_utils: use -security and -updates repo

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1790 from tchaikov/wip-no-quotes-thanks

scripts/build_utils.sh: should not quote --mirror option

scripts/build_utils.sh: should not quote --mirror option

otherwise the URL is not reachable with quotes in it.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1781 from dmick/wip-nfs-ganesha-arm64

Fix up nfs-ganesha for arm64/centos8 builds

Merge pull request #1788 from tchaikov/wip-xunit-thresholds

ceph-pull-requests: specify threshold for a failure

Reviewed-by: David Galloway <dgallowa@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>

Merge pull request #1789 from ceph/wip-allow-focal

multiple PR jobs: Run on any Ubuntu node

multiple PR jobs: Run on any Ubuntu node

All of Jenkins builders are running Ubuntu Focal.  They all have the bionic label.  They also have the xenial label but that's only because we're still building packages *for* Xenial.  But not *on* Xenial.

Signed-off-by: David Galloway <dgallowa@redhat.com>

ceph-pull-requests: specify threshold for a failure

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #1785 from tchaikov/wip-pbuilder

scripts/build_utils: write settings to /root/.pbuilderrc

Reviewed-by: David Galloway <dgallowa@redhat.com>

scripts/build_utils: write settings to /root/.pbuilderrc

according to pbuilder(8)

> ${HOME}/.pbuilderrc
>       The personal configuration file for pbuilder, which overrides settings set in other configuration files.
>
>       Note that ${HOME} is usually /root (if you are running pbuilder through sudo).

since we always call `pbuilder` via `sudo`, we should overwrite
/root/.pbuilderrc with $HOME/.pbuilderrc.

Signed-off-by: Kefu Chai <kchai@redhat.com>

scripts/build_utils: use "pbuilder clean"

"clean" is now a command instead of an option.

Signed-off-by: Kefu Chai <kchai@redhat.com>

script/build_utils.sh: use a single variable for pbuilder options

for better maintainability

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1780 from dmick/wip-xunit-skip

ceph-pull-requests: skip xunit publisher if no test files present

Reviewed-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1782 from tchaikov/wip-gcc-9-bionic

scripts/build_utils.sh: use gcc-9 from ppa on bionic

Merge pull request #1784 from tchaikov/wip-dashboard-py3

ceph-dashboard-pull-requests: install python3 packages only

Reviewed-by: Laura Paduano <lpaduano@suse.com>

ceph-dashboard-pull-requests: install python3 packages only

since we've moved to ubuntu focal for running "make check", "ceph-dashboard-pull-requests"
and "ceph-pr-api" tests. and ubuntu focal does not package python2 packages
for python-scipy or python-routes. let's just install the python3
packages.

this change is related to nautilus builds. because nautilus is the last
release which supports python2.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1783 from tchaikov/wip-api-test-python2

ceph-{api-nightly,pr-api}: install python3 packages on debian derivat…

Reviewed-by: Laura Paduano <lpaduano@suse.com>

ceph-{api-nightly,pr-api}: install python3 packages on debian derivatives

since we've moved to ubuntu focal for running "make check" and
"ceph-pr-api" tests. and ubuntu focal does not package python2 packages
for python-scipy or python-routes. let's just install the python3
packages.

this change is related to nautilus builds. because nautilus is the last
release which supports python2.

Signed-off-by: Kefu Chai <kchai@redhat.com>

Merge pull request #1778 from dmick/wip-tcmu-runner-arm64

tcmu-runner: add arm64

scripts/build_utils.sh: use gcc-9 from ppa on bionic

for using more C++17 compliant compiler

Signed-off-by: Kefu Chai <tchaikov@gmail.com>