osd/scrub: removing PgScrubber's ref to the primary scrub map

as caching this reference (to an object that is owned by the
scrubber backend) creates a dangling-pointer risk.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: change missing_digest fix-list type

...allowing for efficient creation and, more important,
direct consumption by the function performing the
actual I/O.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: scrub components embedded documentation

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: add to PgScrubber a local ref to next-scrub's details

The owner is still the PG.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: minor fixes split from main "scrub backend" commit

Reformatting, minor compiler warnings, etc.
Split from "osd/scrub: extract scrub backend code into separate classes"

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd/scrub: extract scrub backend code into separate classes

A refactoring of the scrub backend code (all Scrub related code
that checks/manipulates objects' (meta)data).

Part of the refactoring was breaking long chunks of code into
separate functions. In order to avoid passing endless lists
of state parameters from/to these new methods, the scrub backend
state is now maintained within its own objects.

a change to note:
Instead of two scrub-map collections - one that holds all
incoming maps, and one that holds pointers to all of those incoming
plus the one we (the Primary) manage - just use one collection
for both incoming and our own.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Split from "osd/scrub: minor fixes split from main "scrub backend" commit"

Split from "osd/scrub: scrub components embedded documentation"

fix

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
osd/scrub: fix the scrubber backend to include all PR #42735

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

Merge pull request #44604 from mgfritch/c-v-skip-rbd-devs

ceph-volume: show RBD devices as not available

Merge pull request #44687 from sebastian-philipp/gov

doc/governance: Adam King

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #44042 from myoungwon/wip-add-blk-paddr

seastore: add blk_paddr_t

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #44685 from rhcs-dashboard/fix-53950-master

mgr/dashboard: remove feedback module as always-on

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #44665 from guits/cv-sw-logger

ceph-volume: don't use MultiLogger in find_executable_on_host()

Merge pull request #43345 from trociny/wip-osdmaptool-down

tools/osdmaptool: fix possible segfaults when there are down osds

mgr/dashboard: fix openapi-check

Fixes: https://tracker.ceph.com/issues/53950
Signed-off-by: Avan Thakkar <athakkar@redhat.com>

ceph-volume: filter RBD devices from the device inventory

Avoid running `blkid` or deploying OSDs on RBD devices by ensuring they
do not appear in the `ceph-volume inventory`

Fixes: https://tracker.ceph.com/issues/53846
Signed-off-by: Michael Fritch <mfritch@suse.com>

Merge pull request #44675 from rzarzynski/wip-tests-bl-explicit-rebuild

test/bufferlist: assert the rebuild in rebuild_aligned_size_and_memory() actually happens.

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #44677 from zdover23/wip-doc_2022-01-20_weil-crush-sc06pdf-repair

doc/rados: update broken pdf link

Reviewed-by: Neha Ojha <nojha@redhat.com>

doc/governance: Adam King

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>

mgr/dashboard: remove feedback as always-on

It was mistakenly left as always-on

Fixes: https://tracker.ceph.com/issues/53950
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #44557 from kotreshhr/clone-quota-failure

mgr/volumes: Fix subvoume snapshot clone failure

Reviewed-by: Venky Shankar <vshankar@redhat.com>

ceph-volume: install config_template from collection

ceph-ansible@master uses config_template from upstream collection.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

ceph-volume: don't use MultiLogger in find_executable_on_host()

This generates a lot of unnecessary messages on the terminal.

Fixes: https://tracker.ceph.com/issues/53934
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

doc/rados: update broken pdf link

This PR repairs a link to a PDF. The link was broken
when the PDF assets were moved during the restructure
of the ceph.io website in 2021.

Signed-off-by: Zac Dover <zac.dover@gmail.com>

test/bufferlist: assert the rebuild in rebuild_aligned_size_and_memory() actually happens.

For the investigation of failures like the following one:

```
[ RUN      ] BufferList.rebuild_aligned_size_and_memory
../src/test/bufferlist.cc:1865: Failure
Expected equality of these values:
  bl.get_num_buffers()
    Which is: 2
  1
[  FAILED  ] BufferList.rebuild_aligned_size_and_memory (0 ms)
```

The test case assumes the rebuild before the failed clause **always**
happens while `bufferlist::rebuild_aligned_size_and_memory()` skips it
if buffers are already aligned.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #44615 from ceph/wip-yuriw-crontab-master

qa/tests: run upgrades on quincy

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #44617 from cbodley/wip-rgw-swift-bulk-upload-no-such-bucket

rgw/swift: don't crash on nonexistent bucket in BulkUpload

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #44601 from trociny/wip-53888

cls/journal: skip disconnected clients when calculating min_commit_position

Reviewed-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #44381 from ly798/add-ns-to-snap-dump

cls/rbd: add namespace to snapshot dump results

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #44553 from kamoltat/wip-ksirivad-progress-mgr-enforce-key-error-exception

pybind/mgr/progress: enforced try and except on event dictionary
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #44024 from rhcs-dashboard/fix-53334-master

mgr/dashboard: Improve notifications for osd nearfull, full

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #44238 from rhcs-dashboard/fix-51575-fix

mgr/dashboard: Notification banners at the top of the UI have fixed height

Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

Merge pull request #44332 from rhcs-dashboard/grafana-warnings

monitoring/grafana: Replace missing legendFormat warning with error.

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #44600 from phlogistonjohn/jjm-mirror-service-module

mgr/cephadm: auto-enable mirroring module when deploying service

Reviewed-by: Michael Fritch <mfritch@suse.com>

Merge pull request #44647 from melissa-kun-li/remove-duplicate-deployment-doc

doc/cephadm: remove duplicate deployment scenario section

Reviewed-by: Adam King <adking@redhat.com>

mgr/dashboard: Improve notifications for osd nearfull, full

This PR adds some visual hints for osds that are near full or full

Fixes: https://tracker.ceph.com/issues/53334
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

Merge pull request #44430 from 5cs/fix-check-pg-num-underflow

mon/OSDMonitor: fix integer underflow of check_pg_num

Reviewed-by: Kefu Chai <kchai@redhat.com>

doc/cephadm: remove duplicate deployment scenario section

Signed-off-by: Melissa Li <melissali@redhat.com>

Merge pull request #43732 from pdvian/wip-limit-slowop

osd/OSD: Log aggregated slow ops detail to cluster logs

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>

Merge pull request #44578 from rhcs-dashboard/fix-53843-master

qa/dashboard: ensure node 16 is installed

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: David Galloway <dgallowa@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: sebastian-philipp <NOT@FOUND>
Reviewed-by: Yuri Weinstein <yweins@redhat.com>

Merge pull request #44607 from rhcs-dashboard/fix-autopep8-qa-tasks

mgr/dashboard: include autopep8 for dashboard qa tasks

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #44575 from rhcs-dashboard/dashboard-cephadm-more-stability

mgr/dashboard: Refactoring dashboard cephadm checks

Reviewed-by: Waad Alkhoury <walkhour@redhat.com>
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>

Merge pull request #42603 from cypherean/feedback_frontend

mgr/dashboard: report ceph tracker bug/feature through GUI

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>

mgr/cephadm: add a test for enabling cephfs mirroring module

Add a test that checks that when cephfs mirror service is enabled
the mirroring mgr module gets enabled.

Actually-written-by: Sebastian Wagner <sewagner@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>

mgr/cephadm: auto-enable mirroring module when deploying service

Automatically enable the mgr's mirroring module when creating
cephfs-mirror services. This will trigger a mgr respawn.

Fixes: https://tracker.ceph.com/issues/50593
Based roughly on 50dc1d0decb2fbf7b9129bddba940969410be5cd

Signed-off-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #33934 from cbodley/wip-40177

rgw: delete full sync index before switching to incremental sync

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #40011 from cbodley/wip-49723

rgw: allow rgw_data_notify_interval_msec=0 to disable notifications

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #44581 from cbodley/wip-53177

rgw/dbstore: hide dbstore_log.h from rgw_main.cc

Reviewed-by: Soumya Koduri <skoduri@redhat.com>

Merge pull request #44413 from cybozu/rgw-fix-error-code-of-remove-bucket-api

rgw: remove bucket API returns NoSuchKey than NoSuchBucket

Reviewed-by: Sébastien Han <seb@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #44078 from cbodley/wip-rgw-multisite-metadata-retry-error

rgw/multisite: metadata sync only retries on errors

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>

Merge pull request #44602 from neha-ojha/wip-qct-remove

doc/foundation.rst: qct is no longer a member

Reviewed-by: Dan van der Ster <daniel.vanderster@cern.ch>

seastore/seastore_types: fix wrong masking

Fix bit operation due to device_id_t is 8 bit for now

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

seastore/random_block_manager: use paddr_t instead of uint64

Reagarding read() and write(), use paddr_t as input parameter
instead of uint64

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

seatore/random_block_manager: remove blocks_per_segment

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

seastore: changes due to adding blk_paddr_t

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

seastore: add blk_paddr_t

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

mgr/dashboard: Refactoring dashboard cephadm checks

I isolated all the tests suites into there respective files
so that in future it is easier to add more tests to it.

I also given priority to the host actions.

Create OSD checks are now written in a way that OSDs
are created only on the intended hosts. This will make
the host draining process easier and less time consuming.

Also tried to address the flaky force maintenance checks.

Removed some duplicated codes

Service creation part improved to reduce the time taken
for its completion

Fixes: https://tracker.ceph.com/issues/53905
Signed-off-by: Nizamudeen A <nia@redhat.com>

Merge pull request #44505 from guits/fix-53812

ceph-volume: fix regression introcuded via #43536

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Teoman Onay <tonay@redhat.com>

Merge pull request #44489 from adk3798/agent-down-alerts

mgr/cephadm: still check agent deps if it is marked down

monitoring/grafana: replace filestore osd count

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>

monitoring/grafana: use Path class instead of split

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>

monitoring/grafana: remove explicit str casting

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>

monitoring/grafana: add generated json files

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>

monitoring/grafana: ValueError instead of RuntimeError

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>

monitoring/grafana: Replace missing legendFormat warning with error

Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>

qa/cephadm: install hwe kernel only for focal

Let's install hwe kernel only on Ubuntu focal, otherwise we only shift the
problem on Ubuntu bionic given that the hwe kernel for bionic is 5.4.

Fixes: https://tracker.ceph.com/issues/53863
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

seastore: rename segment_off_t to seastore_off_t

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>

Merge pull request #44591 from athanatos/sjust/wip-seastore-flush

crimson/os/seastore: avoid empty Transactions by adding explicit flush() call

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #44556 from cyx1231st/wip-crimson-improve-log-journal

crimson/os/seastore: consolidate seastore_journal logs with cleanup and validations

Reviewed-by: Samuel Just <sjust@redhat.com>

rgw: clean up index after full metadata sync

Fixes: https://tracker.ceph.com/issues/40177
Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: clean up index after full data sync

Fixes: https://tracker.ceph.com/issues/40177
Signed-off-by: Casey Bodley <cbodley@redhat.com>

crimson/os/seastore: implement FuturizedStore::flush

Signed-off-by: Samuel Just <sjust@redhat.com>

rgw/swift: don't crash on nonexistent bucket in BulkUpload

Signed-off-by: Casey Bodley <cbodley@redhat.com>

mgr/dashboard: Notification banners at the top of the UI have fixed height

Fixes: https://tracker.ceph.com/issues/51575
Signed-off-by: Waad AlKhoury <walkhour@redhat.com>

qa/rgw: run multisite tests with some async notifications disabled

disable the sending of async datalog notifications on one zone per
cluster. this helps to verify that tests don't rely on notifications to
succeed

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: allow rgw_data_notify_interval_msec=0 to disable notifications

the data changes log for multisite will occasionally broadcast recent
changes to other zones, which they can use to prioritize sync of some
of the most recent changes. they'll eventually see all changes as they
replay the data changes log, though, so notifications aren't required
for successful sync. the ability to turn them off is useful for testing

Fixes: https://tracker.ceph.com/issues/49723
Signed-off-by: Casey Bodley <cbodley@redhat.com>

cls/journal: skip disconnected clients when finding min_commit_position

When a new journal client is registered, all already registered
clients are checked, and a client with min position is selected
as a position for the new client. Thus we may expect that
starting from the registered position all journal entries will be
available (not trimmed) for the new client.

But when looking for a min commit position, the client_register
function did not take into account that a registered client might
be in disconnected state, and in that case the journal entries
might be trimmed for this client.

Fixes: https://tracker.ceph.com/issues/53888
Signed-off-by: Mykola Golub <mgolub@suse.com>

qa/tests: run upgrades on quincy

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

qa/nvme_loop: fix an issue on ubuntu 18.04

The following command:

```
echo /dev/sda | tee /sys/kernel/config/nvmet/subsystems/sda/namespaces/1/device_path
```

makes nvme_loop fail because fascinatingly, it adds an unexpected newline.

See:
```
/dev/sda
/dev/sda

1
tee: /sys/kernel/config/nvmet/subsystems/sda/namespaces/1/enable: No such file or directory
/dev/sda
1
```

Other distros don't have the same behavior:

```
CentOS 8
/dev/sda
/dev/sda
1

Ubuntu 20.04
/dev/sda
/dev/sda
1
```

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

ceph-volume: fix regression introcuded via #43536

The recent changes from PR #43536 introduced a regeression preventing from
running ceph-volume in a containerized context on Ubuntu 18.04.

Given that the path for the binary `lvs` differs between CentOS 8 and Ubuntu 18.04.
(`/usr/sbin/lvs` and `/sbin/lvs` respictively). It means that ceph-volume running
in the container on CentOS 8 sees the `lvs` binary at `/usr/sbin/lvs` and try to
run it with `nsenter` on the host which is running Ubuntu 18.04.

Fixes: https://tracker.ceph.com/issues/53812
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 95e88cda3df76b59b548ae808df0ef7f19db1f63)
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

Merge pull request #44566 from falcon78921/minor-messaging-nit

mgr/cephadm: fix minor grammar nit in Dry-Runs message

mgr/dashboard: report ceph tracker bug/feature through GUI

Fixes: https://tracker.ceph.com/issues/44851
Signed-off-by: Shreya Sharma <shreyasharma.ss305@gmail.com>
Signed-off-by: Avan Thakkar <athakkar@redhat.com>

Merge pull request #44510 from rzarzynski/wip-cephadm-docfix

doc/cephadm: improve the development doc a bit

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #44485 from adk3798/agent-permissions

cephadm: fix permissions on agent files

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>

Merge pull request #44506 from sebastian-philipp/orch-suite-add-scsi

qa/suites/orch/cephadm: Also run the rbd/iscsi suite

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Melissa Li <mingkli@redhat.com>

qa: Add tests snapshot clone failure with quota

Fixes: https://tracker.ceph.com/issues/53848
Signed-off-by: Kotresh HR <khiremat@redhat.com>

mgr/volumes: Fix subvoume snapshot clone failure

Problem:
The subvolume snapshot clone fails if the quota on the source
has exceeded. Since the quota is not strictly enforced at the
byte range, this is a possibility.

Cause:
The quota on the clone is set prior to copying the data
from the source. Hence the quota mostly get enforced before
copying the entire data from the source resulting in the
clone failure.

Solution:
Enforce quota on the clone after the data is copied.

Fixes: https://tracker.ceph.com/issues/53848
Signed-off-by: Kotresh HR <khiremat@redhat.com>

mgr/dashboard: include autopep8 for dashboard qa tasks

Signed-off-by: Avan Thakkar <athakkar@redhat.com>

Merge pull request #44603 from cbodley/wip-cmake-parquet

rgw: disable parquet by default

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

build: revert arrow package dependency

Signed-off-by: Casey Bodley <cbodley@redhat.com>

cmake: disable parquet by default

Signed-off-by: Casey Bodley <cbodley@redhat.com>

doc/foundation.rst: qct is no longer a member

Signed-off-by: Neha Ojha <nojha@redhat.com>

Merge pull request #44523 from ljflores/wip-telemetry-dashboard

mgr/dashboard/telemetry: reduce telemetry dashboard preview size

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: neha-ojha <NOT@FOUND>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Yaarit Hatuka <yaarithatuka@gmail.com>

Merge pull request #44550 from jdurgin/wip-pool-get-quota

mon/OSDMonitor: avoid null dereference if stats are not available

Reviewed-by: Neha Ojha <nojha@redhat.com>

Merge pull request #42735 from amathuria/wip-amathuria-scrub-stats

osd/scrub: Add stats to PG dump for number of objects scrubbed

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>

Merge pull request #43667 from ifed01/wip-ifed-fix-ram-gridy-fsck

os/bluestore: make shared blob fsck much less RAM-greedy.

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>

Merge pull request #44440 from soumyakoduri/wip-skoduri-dbstore-fixes

rgw/dbstore: Misc fixes

Merge pull request #44552 from jdurgin/wip-releases-doc

doc/releases: remove outdated info and versions; mark nautilus eol

Reviewed-by: Neha Ojha <nojha@redhat.com>

rgw/dbstore: hide dbstore_log.h from rgw_main.cc

dbstore_log.h sets global dout_subsys/dout_prefix macros, and was
leaking into rgw_main.cc through the common/dbstore.h. this caused all
of rgw_main's log output to start with the wrong prefix "rgw dbstore: "

Fixes: https://tracker.ceph.com/issues/53177
Signed-off-by: Casey Bodley <cbodley@redhat.com>

qa/dashboard: ensure node 16 is installed

For Ubuntu: https://github.com/nodesource/distributions#manual-installation

Fixes: https://tracker.ceph.com/issues/53843
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #44370 from benhanokh/NCB_expand_device_fix

NCB code doesn't update allocation file when we expand-device

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>

Merge pull request #44251 from yaarith/telemetry-opt-in

mgr/telemetry: introduce new design for varying report data

Reviewed-by: Josh Durgin <jdurgin@redhat.com>