ceph-ci.git
2 months agoMerge pull request #55602 from ceph/wip-yuriw-add-squid-main
Yuri Weinstein [Fri, 16 Feb 2024 15:11:52 +0000 (07:11 -0800)]
Merge pull request #55602 from ceph/wip-yuriw-add-squid-main

qa/tests: added squid option

Reviewed-by: Laura Flores <lflores@redhat.com>
2 months agoMerge pull request #55582 from cbodley/wip-63642
Casey Bodley [Fri, 16 Feb 2024 14:59:31 +0000 (14:59 +0000)]
Merge pull request #55582 from cbodley/wip-63642

rgw/putobj: RadosWriter uses part head object for multipart parts

Reviewed-by: Mark Kogan <mkogan@ibm.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2 months agoMerge pull request #55453 from ronen-fr/wip-rf-0741-logs
Ronen Friedman [Fri, 16 Feb 2024 14:24:13 +0000 (16:24 +0200)]
Merge pull request #55453 from ronen-fr/wip-rf-0741-logs

osd/scrub: improve scheduling decision logs

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 months agoMerge pull request #54856 from linuxbox2/wip-accept-new-awssigv4
Casey Bodley [Fri, 16 Feb 2024 13:52:34 +0000 (13:52 +0000)]
Merge pull request #54856 from linuxbox2/wip-accept-new-awssigv4

rgw: cumulatively fix 6 AWS SigV4 request failure cases

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 months agomon, mgr: do not output network ping stats
Ponnuvel Palaniyappan [Thu, 15 Sep 2022 14:55:06 +0000 (15:55 +0100)]
mon, mgr: do not output network ping stats

When doing PG dump using 'ceph pg dump --format json-pretty'
the output is extremely big that the command hangs and also
the ceph-mgr hangs and eventuall fails over.

The exact size depends on the number of OSDs in the cluster
and the number of peers for each OSD.

In tests, it's been identified that the network ping times
is the largest component in terms of size which is removed
from the output now so as to limit the overall size.

Fixes https://tracker.ceph.com/issues/57460

Signed-off-by: Ponnuvel Palaniyappan <pponnuvel@gmail.com>
2 months agoMerge pull request #55579 from idryomov/wip-64423
Ilya Dryomov [Fri, 16 Feb 2024 09:24:02 +0000 (10:24 +0100)]
Merge pull request #55579 from idryomov/wip-64423

librbd: fix split() for SparseExtent and SparseBufferlistExtent

Reviewed-by: Mykola Golub <mgolub@suse.com>
2 months agoMerge pull request #55530 from trociny/wip-64376
Ilya Dryomov [Fri, 16 Feb 2024 09:22:50 +0000 (10:22 +0100)]
Merge pull request #55530 from trociny/wip-64376

tools/rbd: make 'children' command support --image-id

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 months agotest/osd: fix test_scrub_sched following scrubber changes wip-rf-0741-logs
Ronen Friedman [Mon, 12 Feb 2024 14:50:22 +0000 (08:50 -0600)]
test/osd: fix test_scrub_sched following scrubber changes

Replacing PgScrubber::determine_scrub_time() with a local copy,
as a stop-gap measure to keep the test running.
The scrub scheduling refactoring will remove the need for
this function, and the test will be updated accordingly.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 months agoosd/scrub: log parameter entering scrub_requested()
Ronen Friedman [Mon, 5 Feb 2024 12:02:14 +0000 (06:02 -0600)]
osd/scrub: log parameter entering scrub_requested()

... and a minor formatting fix in the same function.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 months agoMerge pull request #53289 from rzarzynski/wip-mon-set-allow-crimson
Yuri Weinstein [Fri, 16 Feb 2024 00:24:53 +0000 (16:24 -0800)]
Merge pull request #53289 from rzarzynski/wip-mon-set-allow-crimson

mon/OSDMonitor: fix the hint for set-allow-crimson

Reviewed-by: Samuel Just <sjust@redhat.com>
2 months agoMerge pull request #55404 from JoshSalomon/fix-warn
Laura Flores [Fri, 16 Feb 2024 00:20:05 +0000 (18:20 -0600)]
Merge pull request #55404 from JoshSalomon/fix-warn

osd: Fix compilation warnings for PR https://github.com/ceph/ceph/pull/55198

2 months agounittest-seastar-socket: debug to error on unexpected return from dispatch_rw_bounded
Samuel Just [Fri, 16 Feb 2024 00:04:05 +0000 (00:04 +0000)]
unittest-seastar-socket: debug to error on unexpected return from dispatch_rw_bounded

Related: https://tracker.ceph.com/issues/64457
Signed-off-by: Samuel Just <sjust@redhat.com>
2 months agoMerge pull request #54930 from rzarzynski/wip-osd-ec-rework
Laura Flores [Thu, 15 Feb 2024 19:41:31 +0000 (13:41 -0600)]
Merge pull request #54930 from rzarzynski/wip-osd-ec-rework

osd: rework EC for the sake of integration with crimson

2 months agoosd: avoid copying chunks in a loop
Ronen Friedman [Thu, 15 Feb 2024 18:17:57 +0000 (12:17 -0600)]
osd: avoid copying chunks in a loop

to clear a static analyzer warning

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 months agoosd: clean compiler warnings
Ronen Friedman [Thu, 15 Feb 2024 18:11:22 +0000 (12:11 -0600)]
osd: clean compiler warnings

... for unused variables, for code that has no effect, and
for trying to std::move out of a const lvalue.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 months agoqa/tests: added squid option
Yuri Weinstein [Thu, 15 Feb 2024 17:14:12 +0000 (09:14 -0800)]
qa/tests: added squid option

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
2 months agoMerge pull request #55566 from zdover23/wip-doc-2024-02-14-cephadm-services-nfs
Adam King [Thu, 15 Feb 2024 14:42:50 +0000 (09:42 -0500)]
Merge pull request #55566 from zdover23/wip-doc-2024-02-14-cephadm-services-nfs

doc/cephadm: correct nfs config pool name

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
2 months agoMerge pull request #55539 from zdover23/wip-doc-2024-02-12-glossary-osd-terms
zdover23 [Thu, 15 Feb 2024 14:24:49 +0000 (00:24 +1000)]
Merge pull request #55539 from zdover23/wip-doc-2024-02-12-glossary-osd-terms

doc/glossary: improve OSD definitions

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 months agoMerge pull request #55537 from guits/node-proxy-handle-fetch-oob-error
Guillaume Abrioux [Thu, 15 Feb 2024 08:04:20 +0000 (09:04 +0100)]
Merge pull request #55537 from guits/node-proxy-handle-fetch-oob-error

node-proxy: improve http error handling in fetch_oob_details

2 months agoMerge pull request #55297 from VallariAg/fix-gtest-xml-path
Vallari Agrawal [Thu, 15 Feb 2024 04:29:29 +0000 (09:59 +0530)]
Merge pull request #55297 from VallariAg/fix-gtest-xml-path

qa/workunits/rados/test.sh: fix GTEST_OUTPUT path

2 months agodoc/glossary: improve OSD definitions
Zac Dover [Mon, 12 Feb 2024 13:08:27 +0000 (23:08 +1000)]
doc/glossary: improve OSD definitions

Remove expletive construction from three OSD-id-related terms.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 months agoMerge pull request #55585 from zdover23/wip-doc-2024-02-15-rados-operations-placement...
Anthony D'Atri [Wed, 14 Feb 2024 20:28:27 +0000 (15:28 -0500)]
Merge pull request #55585 from zdover23/wip-doc-2024-02-15-rados-operations-placement-groups-sage-blog-post

doc/rados: add link to pg blog post

2 months agoMerge pull request #55584 from batrick/backport-create-squid
Ilya Dryomov [Wed, 14 Feb 2024 18:40:54 +0000 (19:40 +0100)]
Merge pull request #55584 from batrick/backport-create-squid

script: add squid release to backport-create-issue

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 months agoqa: move cert import into rgw task wip-accept-new-awssigv4
Ali Maredia [Mon, 12 Feb 2024 23:25:17 +0000 (18:25 -0500)]
qa: move cert import into rgw task

Signed-off-by: Ali Maredia <amaredia@redhat.com>
2 months agoqa: enable test_awssdkv4_sig workunit to run in teuthology
Ali Maredia [Mon, 5 Feb 2024 16:52:38 +0000 (11:52 -0500)]
qa: enable test_awssdkv4_sig workunit to run in teuthology

Signed-off-by: Ali Maredia <amaredia@redhat.com>
2 months agorgw_sigv4: catch exceptions on client builder
Matt Benjamin [Thu, 8 Feb 2024 19:17:39 +0000 (14:17 -0500)]
rgw_sigv4: catch exceptions on client builder

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 months agoMerge pull request #55533 from ronen-fr/wip-rf-sdocs-1
Ronen Friedman [Wed, 14 Feb 2024 16:31:28 +0000 (18:31 +0200)]
Merge pull request #55533 from ronen-fr/wip-rf-sdocs-1

doc/osd: documentation changes related to scrub

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Zac Dover <zac.dover@proton.me>
2 months agoscript: add squid to backports
Patrick Donnelly [Wed, 14 Feb 2024 15:37:24 +0000 (10:37 -0500)]
script: add squid to backports

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2 months agodoc/rados: add link to pg blog post
Zac Dover [Wed, 14 Feb 2024 15:32:40 +0000 (01:32 +1000)]
doc/rados: add link to pg blog post

Add a link in the "Placement Groups" section that links to Sage Weil's
April 5, 2019 blog post "New in Nautilus: PG merging and autotuning".

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 months agorgw/putobj: RadosWriter uses part head object for multipart parts wip-63642
Casey Bodley [Wed, 14 Feb 2024 14:43:14 +0000 (09:43 -0500)]
rgw/putobj: RadosWriter uses part head object for multipart parts

the cleanup logic in the RadosWrite destructor was using the wrong
`head_obj` to avoid races between cleanup and part re-uploads. it
pointed at the final location of the multipart upload, rather than the
head object of the current part

Fixes: https://tracker.ceph.com/issues/63642
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 months agoMerge pull request #55551 from ivoalmeida/cephfs-mount-details
Ivo Almeida [Wed, 14 Feb 2024 13:48:16 +0000 (10:48 -0300)]
Merge pull request #55551 from ivoalmeida/cephfs-mount-details

mgr/dashboard: added cephfs mount details

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2 months agolibrbd: refactor merge() for SparseBufferlistExtent
Ilya Dryomov [Mon, 12 Feb 2024 12:07:22 +0000 (13:07 +0100)]
librbd: refactor merge() for SparseBufferlistExtent

- pass left.length + right.length instead of bl.length()
  for consistency and to avoid circumventing the assert in
  SparseBufferlistExtent constructor
- claim_append() takes an lvalue reference, no need to move
- follow the pattern used in split()

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 months agolibrbd: fix split() for SparseExtent and SparseBufferlistExtent
Ilya Dryomov [Mon, 12 Feb 2024 10:00:45 +0000 (11:00 +0100)]
librbd: fix split() for SparseExtent and SparseBufferlistExtent

SparseExtents and SparseBufferlist are typedefs for interval_map.  In
both cases, split() handler is broken: for the former the extent isn't
actually split and for the latter incorrect bufferlist is attached to
the split extent.

Fortunately, both SnapshotDelta as produced by ObjectListSnapsRequest
and SparseBufferlist used in a couple of places seem to be collections
where only disjoint intervals are inserted and splitting doesn't occur
(at least in the common case).  But still, this is a landmine waiting
for someone to step on it.

Fixes: https://tracker.ceph.com/issues/64423
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2 months agoMerge pull request #55577 from cityofships/typo
Anthony D'Atri [Wed, 14 Feb 2024 13:02:11 +0000 (08:02 -0500)]
Merge pull request #55577 from cityofships/typo

doc/start: fix wording & syntax

2 months agodoc/osd: fix 'scrub a PG' commands in the documentation wip-rf-sdocs-1
Ronen Friedman [Sun, 11 Feb 2024 17:53:44 +0000 (19:53 +0200)]
doc/osd: fix 'scrub a PG' commands in the documentation

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 months agodoc/start: fix wording & syntax
Piotr Parczewski [Wed, 14 Feb 2024 10:15:09 +0000 (11:15 +0100)]
doc/start: fix wording & syntax

Signed-off-by: Piotr Parczewski <piotr@stackhpc.com>
2 months agomgr/dashboard: added cephfs mount details
Ivo Almeida [Mon, 12 Feb 2024 10:08:09 +0000 (10:08 +0000)]
mgr/dashboard: added cephfs mount details

Fixes: https://tracker.ceph.com/issues/64405
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
2 months agomgr/cephadm: add fullreport in ceph orch CLI (node-proxy)
Guillaume Abrioux [Wed, 14 Feb 2024 09:02:50 +0000 (09:02 +0000)]
mgr/cephadm: add fullreport in ceph orch CLI (node-proxy)

This adds the `fullreport` category to the `ceph orch hardware status` CLI.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 months agomgr/cephadm: conditionally deploy node-proxy
Guillaume Abrioux [Mon, 12 Feb 2024 16:20:42 +0000 (16:20 +0000)]
mgr/cephadm: conditionally deploy node-proxy

Only attempt to deploy the node-proxy agent when oob details
are provided for a given host.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 months agonode-proxy: call time.sleep() after each reporter iteration
Guillaume Abrioux [Mon, 12 Feb 2024 14:25:24 +0000 (14:25 +0000)]
node-proxy: call time.sleep() after each reporter iteration

This makes sure time.sleep() is always call in the reporter loop.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 months agonode-proxy: improve http error handling in fetch_oob_details
Guillaume Abrioux [Mon, 12 Feb 2024 12:22:41 +0000 (12:22 +0000)]
node-proxy: improve http error handling in fetch_oob_details

This makes the daemon handle the error nicer in fetch_oob_details()

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2 months agoMerge pull request #54295 from rhcs-dashboard/edit-bucket-acl-tags
Nizamudeen A [Wed, 14 Feb 2024 07:38:26 +0000 (13:08 +0530)]
Merge pull request #54295 from rhcs-dashboard/edit-bucket-acl-tags

mgr/dashboard: add ACLs

Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 months agomgr/dashboard: update nvmeof protoc to 1.0.0
Nizamudeen A [Mon, 12 Feb 2024 06:11:32 +0000 (11:41 +0530)]
mgr/dashboard: update nvmeof protoc to 1.0.0

Fixes: https://tracker.ceph.com/issues/64384
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 months agoMerge PR #54690 into main
Venky Shankar [Wed, 14 Feb 2024 05:10:49 +0000 (10:40 +0530)]
Merge PR #54690 into main

* refs/pull/54690/head:
client: handle callback completion if the async I/O failed
client: make sure the callback is finished when returning ENOTCONN
client: do not accept zero byte write request
client: check for negative value of iovcnt
src/test: test zero bytes async i/o
src/test: test async I/O with negative iov structures count
src/test: test async I/O if the client is not mounted
src/test: test async I/O with read only file
src/test: test async I/O with a file created with O_PATH

Reviewed-by: Frank S. Filz <ffilzlnx@mindspring.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
2 months agoosd: always send returnvec-on-errors for client's retry
Radoslaw Zarzynski [Wed, 14 Feb 2024 00:38:46 +0000 (00:38 +0000)]
osd: always send returnvec-on-errors for client's retry

Currently there is a discrepancy in terms of the returnvec's
presence between MOSDOpReplys sent for original requests and
those on dups. The former always contain the returnvec if
an error happened, even if `allows_returnvec()` is `false`.

This commit extends the behavior on dups.

For RCA please see: https://tracker.ceph.com/issues/64192#note-9

Fixes: https://tracker.ceph.com/issues/64192
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 months agorgw_sigv4: fixes to bootstrap maven/junit5 suite
Matt Benjamin [Fri, 2 Feb 2024 19:59:20 +0000 (14:59 -0500)]
rgw_sigv4: fixes to bootstrap maven/junit5 suite

The junit5 suite in fact chooses selects transport security (SSL)
strictly from the endpoint URL.  The test_awssdkv4_sig.sh (or its
caller?) only needs to export RGW_HTTP_ENDPOINT_URL appropriately
to get one or the other.

Fix several mistakes in refactoring caught by Ali Maredia.
Print AccessKey, SecretKey and EndpointURL on startup

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 months agoawssigv4: fix recognition of trailer boundary when no trailing signature
Matt Benjamin [Sat, 13 Jan 2024 18:57:36 +0000 (13:57 -0500)]
awssigv4: fix recognition of trailer boundary when no trailing signature

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 months agoawssigv4: fix signing of 0-byte object
Matt Benjamin [Thu, 11 Jan 2024 23:12:22 +0000 (18:12 -0500)]
awssigv4: fix signing of 0-byte object

1. correctly match signature of 0-length chunk
2. initialize lf_bytes

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 months agorgw_cksum: add junit5-based unit test suite
Matt Benjamin [Fri, 5 Jan 2024 15:40:49 +0000 (10:40 -0500)]
rgw_cksum: add junit5-based unit test suite

This can be run by hand with:

./mvnw clean package
./mvnw test -Dtest=PutObjects

The following properties are sourced from the environment:

    AWS_ACCESS_KEY_ID
    AWS_SECRET_ACCESS_KEY

    RGW_HTTP_ENDPOINT_URL
    RGW_HTTPS_ENDPOINT_URL

Then adds:

qa/workunits/rgw: add test driver script for maven suite

Launch it fromn cls.yaml, as with test_librgw_file.h.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 months agorgw: cumulatively fix 6 AWS SigV4 request failure cases
Matt Benjamin [Mon, 27 Nov 2023 17:00:43 +0000 (12:00 -0500)]
rgw: cumulatively fix 6 AWS SigV4 request failure cases

These changes address checksum header identification and signing
algorithm selection, including checksum trailer verification
for signed- and unsigned-payload cases.

These changes address all the actual S3 request failures I have
so far been able to reproduce, with and without content checksums
and/or new trailing checksum headers, and with and without
SSL.

Fixes: https://tracker.ceph.com/issues/63153
Specifically, it fixes the request failures that motivated the
initial tracker filing.  It extracts but does not validate new client
content checksums if present.  Validation and management of new
S3 content-checksum headers will follow in a subsequent change.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
squashed commits:

* wip chunk meta parsing--seem to have first AWSv4ComplMulti::ChunkMeta::create_next sort of parsing
* use constexpr sarlen(...) for static array lengths throughout rgw_auth_s3.cc
* link AWSv4CompleMulti::ChunkMeta to its enclosing completer
* capture original content-length header before AWSv4ComplMulti overwrites it
* mostly extract the trailer
* fix misordered content-length, experiment w/exbuf
* save leftover bytes between calls to AWSv4ComplMulti::recv_chunk()
* propagate data_offset_in_stream from AWSv4ComplMulti::recv_chunk()
* clean up trailer section extract
* trailer section cleanup and introduce extract_helper
* unrolled checksum extract--fixup
* fix sv_trailer end pos, and cleanup
* add proplist interface to rgw::auth::Completer and AWSv4ComplMulti
* spliterate trailers
* check completer props
* redefine prop_map to point into already-allocated trailer_vec
* hax: thread a counter onto AWSv4ComplMulti recv_body() and recv_chunk path
* fix apparent bug where due to reads less than chunk_size induce a final, zero-length read that was skipped before forcing recognition of the last chunk in the stream
* check only for a trailing checksum named in x-amz-trailer
* don't try to match signatures when no signature provided (because streaming unsigned)
* oops, fix content_length decl
* fix recognition of next chunk envelope in unsigned aws-chunk case
* clean up AWSv4CompMulti flags and correctly detect aws unsigned chunked
* rework checksum-trailer extraction and introduce AWSv4ComplMulti::calc_v4_trailing_signature
* thread const struct req_state* into AWSv4ComplMulti
* large cleanup of trailer parsing, no regression
* fix trailer signature calculation--checks
* correctly generate final chunk hmac
* typo in comment
* verify trailing signature when expected (using expected final chunk signature)
* move trailer_vec back onto recv_body()'s stack
* remove strange completer comment
* remove last_frag (now points into parsing_buf)
* remove implied dependency on content_length
* move trailer recognition to AWSv4ComplMulti::complete()
* remove now-unused is_last_chunk() predicate
* remove unused ChunkMeta::completer
* responses to review comments
* when trailer is sig expected, fail (only) if none present or if it does not match calculated
* remove stale parse_content_length(...) decl
* remove now-unused AWSv4ComplMulti::content_length
* fix extract_helper end search position as in mut_extract_helper
* change "\n" reserve term in get_canon_amz_hdrs() part of the sum (review)
    and initialize length to 0
* remove debugging code

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2 months agodoc/cephadm: correct nfs config pool name
Zac Dover [Tue, 13 Feb 2024 17:04:26 +0000 (03:04 +1000)]
doc/cephadm: correct nfs config pool name

s/nfs-ganesha/.nfs/ in doc/cephadm/services/nfs, in accordance with
information given to me by John Mulligan over Slack.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 months agotools/rbd: make 'children' command support --image-id
Mykola Golub [Sun, 11 Feb 2024 09:43:30 +0000 (09:43 +0000)]
tools/rbd: make 'children' command support --image-id

Fixes: https://tracker.ceph.com/issues/64376
Signed-off-by: Mykola Golub <mykola.golub@clyso.com>
2 months agoMerge pull request #55521 from ivoalmeida/snapshot-schedule-subvolume-copies
Ivo Almeida [Tue, 13 Feb 2024 12:16:30 +0000 (09:16 -0300)]
Merge pull request #55521 from ivoalmeida/snapshot-schedule-subvolume-copies

mgr/dashboard: snapshot schedule added subvolume and translations

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 months agomgr/dashboard: add ACLs
Pedro Gonzalez Gomez [Wed, 1 Nov 2023 15:06:49 +0000 (16:06 +0100)]
mgr/dashboard: add ACLs

Fixes: https://tracker.ceph.com/issues/63547
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 months agodoc: add the reject the clone when threads are not available feature in the document
neeraj pratap singh [Tue, 22 Aug 2023 08:02:58 +0000 (13:32 +0530)]
doc: add the reject the clone when threads are not available feature in the document

Fixes: https://tracker.ceph.com/issues/59714
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
2 months agoqa: add test cases for the support to reject clones feature
neeraj pratap singh [Tue, 22 Aug 2023 07:12:21 +0000 (12:42 +0530)]
qa: add test cases for the support to reject clones feature

Fixes: https://tracker.ceph.com/issues/59714
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
2 months agoMerge pull request #54959 from VallariAg/wip-nvmeof-test-v2
Vallari Agrawal [Tue, 13 Feb 2024 07:50:42 +0000 (13:20 +0530)]
Merge pull request #54959 from VallariAg/wip-nvmeof-test-v2

qa: add qa/tasks/nvmeof.py

2 months agoMerge pull request #55314 from cloudbehl/rgw-dashboard-json
Aashish Sharma [Tue, 13 Feb 2024 06:30:33 +0000 (12:00 +0530)]
Merge pull request #55314 from cloudbehl/rgw-dashboard-json

mgr/dashboard: Fixing RGW graph panels

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
2 months agodashboard/rgw: changes to use 'full_user_id' from rgw
Pritha Srivastava [Mon, 12 Feb 2024 07:02:11 +0000 (12:32 +0530)]
dashboard/rgw: changes to use 'full_user_id' from rgw
user info as 'uid' in dashboard. 'full_user_id' includes
tenant and user id, and also namespace wherever it is non
empty.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 months agoMerge pull request #55546 from zdover23/wip-doc-2024-02-13-glossary-crush
zdover23 [Tue, 13 Feb 2024 00:00:52 +0000 (10:00 +1000)]
Merge pull request #55546 from zdover23/wip-doc-2024-02-13-glossary-crush

doc/glossary: Add link to CRUSH paper

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 months agoMerge pull request #53527 from rhcs-dashboard/add-rgw-perf-counter-cache
Adam King [Mon, 12 Feb 2024 23:34:48 +0000 (18:34 -0500)]
Merge pull request #53527 from rhcs-dashboard/add-rgw-perf-counter-cache

cephadm/rgw: make rgw perf counters cache and it's size configurable

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Ali Maredia <amaredia@redhat.com>
2 months agoMerge pull request #55355 from adk3798/cephadm-nvmeof-version-bug
Adam King [Mon, 12 Feb 2024 23:21:25 +0000 (18:21 -0500)]
Merge pull request #55355 from adk3798/cephadm-nvmeof-version-bug

cephadm: fix get_version for nvmeof

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2 months agoMerge pull request #50422 from rzarzynski/wip-bug-58915
Radoslaw Zarzynski [Mon, 12 Feb 2024 19:22:47 +0000 (20:22 +0100)]
Merge pull request #50422 from rzarzynski/wip-bug-58915

osd: don't send stale hb msgr's addresses in MOSDBoot

Reviewed-by: Laura Flores <lflores@redhat.com>
2 months agoMerge pull request #55156 from alimaredia/wip-rgw-add-cap-user-without-keys
Ali Maredia [Mon, 12 Feb 2024 18:35:09 +0000 (13:35 -0500)]
Merge pull request #55156 from alimaredia/wip-rgw-add-cap-user-without-keys

rgw: add new cap user-info-without-keys

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 months agofixup: don't store ref-to-on-stack-temporary in RecoveryBackend::coll
Radoslaw Zarzynski [Mon, 12 Feb 2024 17:40:06 +0000 (17:40 +0000)]
fixup: don't store ref-to-on-stack-temporary in RecoveryBackend::coll

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 months agoMerge pull request #55487 from cbodley/wip-qa-rgw-hadoop-distro
Casey Bodley [Mon, 12 Feb 2024 17:05:33 +0000 (17:05 +0000)]
Merge pull request #55487 from cbodley/wip-qa-rgw-hadoop-distro

qa/rgw: hadoop-s3a uses supported-random-distro$

Reviewed-by: Ali Maredia <amaredia@redhat.com>
2 months agoMerge pull request #55360 from shreyanshjain7174/fix_2252048
Casey Bodley [Mon, 12 Feb 2024 17:05:02 +0000 (17:05 +0000)]
Merge pull request #55360 from shreyanshjain7174/fix_2252048

RGW: Getting an RGW service Segfault when assigning an attribute to an IAM role.

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 months agoMerge pull request #55486 from jzhu116-bloomberg/wip-64340
Casey Bodley [Mon, 12 Feb 2024 17:04:33 +0000 (17:04 +0000)]
Merge pull request #55486 from jzhu116-bloomberg/wip-64340

rgw: do not copy olh attributes in versioning suspended bucket

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 months agoMerge pull request #55458 from tobias-urdin/cors-signature
Casey Bodley [Mon, 12 Feb 2024 17:03:49 +0000 (17:03 +0000)]
Merge pull request #55458 from tobias-urdin/cors-signature

rgw/auth: ignoring signatures for HTTP OPTIONS calls

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 months agomgr/dashboard: added subvolume and translations
Ivo Almeida [Thu, 8 Feb 2024 15:23:42 +0000 (15:23 +0000)]
mgr/dashboard: added subvolume and translations

This commit adds support for subvolume snap scheduling and translations for snap schedule repeat schedules and retention policies

Fixes: https://tracker.ceph.com/issues/64372
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
2 months agoMerge pull request #55347 from lightmelodies/mon
Yuri Weinstein [Mon, 12 Feb 2024 16:05:33 +0000 (08:05 -0800)]
Merge pull request #55347 from lightmelodies/mon

mon: fix health store size growing infinitely

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>
2 months agoMerge pull request #55251 from rzarzynski/wip-bug-64104
Yuri Weinstein [Mon, 12 Feb 2024 16:04:54 +0000 (08:04 -0800)]
Merge pull request #55251 from rzarzynski/wip-bug-64104

tools/cot: respect generic, Ceph-wide argvs

Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
2 months agodoc/glossary: Add link to CRUSH paper
Zac Dover [Mon, 12 Feb 2024 15:06:05 +0000 (01:06 +1000)]
doc/glossary: Add link to CRUSH paper

Add a link in the CRUSH definition to the original CRUSH paper.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 months agoqa: add qa/tasks/nvmeof.py and rbd/nvmeof_basic_task and fio workunits
Vallari Agrawal [Thu, 1 Feb 2024 13:07:27 +0000 (18:37 +0530)]
qa: add qa/tasks/nvmeof.py and rbd/nvmeof_basic_task and fio workunits

This is v2 of the rbd/nvmeof test: It deploys 1 gateway and 1 initiator.
Then does basic verification on nvme commands and runs fio.

This commit creates:
1. qa/tasks/nvmeof.py: adds a new 'Nvmeof' task which deploys
    the gateway and shares config with the initiator hosts.
    Sharing config was previously done by 'nvmeof_gateway_cfg' task
    in qa/tasks/cephadm.py (that task is removed in this commit).
2. qa/workunits/rbd/nvmeof_basic_tests.sh:
    Runs nvme commands (discovery, connect, connect-all, disconnect-all,
    and list-subsys) and does basic verification of the output.
3. qa/workunits/rbd/nvmeof_fio_test.sh:
    Runs fio command. Also runs iostat in parallel if IOSTAT_INTERVAL
    variable is set. This variable configures the delay between each iostat
    print.

nvmeof-cli upgrade from v0.0.6 to v0.0.7 introduced major changes
to all nvmeof commands. This commit changes v0.0.6 commands to
v0.0.7 in qa/workunits/rbd/nvmeof_initiator.sh

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
2 months agoMerge pull request #55467 from rhcs-dashboard/rgw-s3-analytics-grafana-dashboard
Aashish Sharma [Mon, 12 Feb 2024 07:16:48 +0000 (12:46 +0530)]
Merge pull request #55467 from rhcs-dashboard/rgw-s3-analytics-grafana-dashboard

mgr/dashboard: Add RGW per user/bucket panels in  grafana

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 months agoMerge pull request #55494 from ivoalmeida/snapshot-schedule-delete-activate
Nizamudeen A [Mon, 12 Feb 2024 06:28:03 +0000 (11:58 +0530)]
Merge pull request #55494 from ivoalmeida/snapshot-schedule-delete-activate

mgr/dashboard: added delete and activation actions

Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 months agoMerge pull request #55529 from tchaikov/cmake-cap
Kefu Chai [Mon, 12 Feb 2024 01:23:21 +0000 (09:23 +0800)]
Merge pull request #55529 from tchaikov/cmake-cap

cmake: find_package(cap) before linking against it

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 months agomgr/dashboard: added delete and activation actions
Ivo Almeida [Wed, 7 Feb 2024 14:03:45 +0000 (14:03 +0000)]
mgr/dashboard: added delete and activation actions

Fixes: https://tracker.ceph.com/issues/64355
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
2 months agodoc/osd: update the documentation of several scrub-related options
Ronen Friedman [Sun, 11 Feb 2024 17:32:19 +0000 (19:32 +0200)]
doc/osd: update the documentation of several scrub-related options

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 months agoMerge pull request #55528 from tchaikov/cmake-boost-debug
Kefu Chai [Sun, 11 Feb 2024 16:39:04 +0000 (00:39 +0800)]
Merge pull request #55528 from tchaikov/cmake-boost-debug

cmake: build boost debug variant when CMAKE_BUILD_TYPE is Debug

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 months agoMerge pull request #55199 from igomon-bloomberg/wip-publish-commit-async
Casey Bodley [Sun, 11 Feb 2024 16:15:17 +0000 (16:15 +0000)]
Merge pull request #55199 from igomon-bloomberg/wip-publish-commit-async

rgw/s3-notifications: async commit to persistent notification queue

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2 months agoMerge pull request #55371 from pritha-srivastava/wip-rgw-correct-err-msg
Casey Bodley [Sun, 11 Feb 2024 16:14:42 +0000 (16:14 +0000)]
Merge pull request #55371 from pritha-srivastava/wip-rgw-correct-err-msg

rgw/auth: correcting the error message to indicate

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 months agoMerge pull request #55250 from cbodley/wip-64084
Casey Bodley [Sun, 11 Feb 2024 16:12:48 +0000 (16:12 +0000)]
Merge pull request #55250 from cbodley/wip-64084

rgw/auth/s3: validate x-amz-content-sha256 for empty payloads

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2 months agoMerge pull request #55478 from ronen-fr/wip-rf-update-times
Ronen Friedman [Sun, 11 Feb 2024 11:25:47 +0000 (13:25 +0200)]
Merge pull request #55478 from ronen-fr/wip-rf-update-times

osd: restoring timely collection of PG stats

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2 months agocmake: find_package(cap) before linking against it
Kefu Chai [Sun, 11 Feb 2024 08:53:26 +0000 (16:53 +0800)]
cmake: find_package(cap) before linking against it

before this change, we link against libcap without finding it. this
works fine as long as libcap-devel or libcap-dev is installed in the
system. but if it is not, the source would fail to build due to missing
`sys/capability.h`. this is not a great developer experience.

in this change, a `Findcap.cmake` is added to find the capability
library. which would fail the build at the configure phase.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 months agocmake: build boost debug variant when CMAKE_BUILD_TYPE is Debug
Kefu Chai [Sun, 11 Feb 2024 07:42:14 +0000 (15:42 +0800)]
cmake: build boost debug variant when CMAKE_BUILD_TYPE is Debug

boost has some different predefined  build variants. they are quite
like CMake's CMAKE_BUILD_TYPE. in which, "debug" enables some
features related features. so it would be nice if we can have it
enabled for the Debug build, if the boost is built from source.
see also
https://www.boost.org/build/doc/html/bbv2/overview/builtins/features.html

before this change, we always build the "release" variant.  in this
change, "debug" variant is built if Ceph's is built with
CMAKE_BUILD_TYPE=Debug. please note, this change does not change
the way how boost is built when packaging Ceph, as our debian/rpm
receipts do not define CMAKE_BUILD_TYPE and respect the distros'
settings, in that case, the "release" variant is still built.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2 months agoMerge pull request #55525 from zdover23/wip-doc-2024-02-11-radosgw-55524-rollback
zdover23 [Sat, 10 Feb 2024 14:47:59 +0000 (00:47 +1000)]
Merge pull request #55525 from zdover23/wip-doc-2024-02-11-radosgw-55524-rollback

doc/radosgw: undo 55524

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 months agodoc/radosgw: undo 55524
Zac Dover [Sat, 10 Feb 2024 14:36:29 +0000 (00:36 +1000)]
doc/radosgw: undo 55524

Roll back the docs changes made in
https://github.com/ceph/ceph/pull/55524, in accordance with Casey
Bodley's instructions to me here:
https://github.com/ceph/ceph/pull/55524#issuecomment-1937020543.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 months agoMerge pull request #55524 from zdover23/wip-doc-2024-02-10-radosgw-lua-scripting...
Anthony D'Atri [Sat, 10 Feb 2024 11:30:41 +0000 (06:30 -0500)]
Merge pull request #55524 from zdover23/wip-doc-2024-02-10-radosgw-lua-scripting-options

doc/radosgw: remove invalid LUA context options

2 months agoMerge pull request #55507 from ljflores/wip-tracker-64343
Laura Flores [Sat, 10 Feb 2024 05:36:21 +0000 (23:36 -0600)]
Merge pull request #55507 from ljflores/wip-tracker-64343

2 months agodoc/radosgw: remove invalid LUA context options
Zac Dover [Sat, 10 Feb 2024 03:14:59 +0000 (13:14 +1000)]
doc/radosgw: remove invalid LUA context options

Remove "background", "getdata", and "putdata" from the list of LUA
context options. Passing these options throws the following error:
"ERROR: invalid script context: background. must be one of: preRequest,
postRequest".

Fixes: https://tracker.ceph.com/issues/64327
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 months agoqa/suites/orch: whitelist warnings that are expected in test environments
Laura Flores [Thu, 8 Feb 2024 22:14:03 +0000 (16:14 -0600)]
qa/suites/orch: whitelist warnings that are expected in test environments

Fixes: https://tracker.ceph.com/issues/64343
Signed-off-by: Laura Flores <lflores@ibm.com>
2 months agorgw/datalog: RGWDataChangesLog::add_entry() uses null_yield
Casey Bodley [Fri, 9 Feb 2024 18:38:49 +0000 (13:38 -0500)]
rgw/datalog: RGWDataChangesLog::add_entry() uses null_yield

work around a deadlock under RGWDataChangesLog::add_entry() with
multi-object delete by making the push() call synchronous

this is a partial revert of d38a69b6e18cb798528d64a2c6c3e439212fe6d2

Fixes: https://tracker.ceph.com/issues/63373
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 months agotest/rgw: add multisite test case for DeleteObjects
Casey Bodley [Fri, 9 Feb 2024 17:49:10 +0000 (12:49 -0500)]
test/rgw: add multisite test case for DeleteObjects

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 months agorgw: if head object does not have data, still include in `object manifest`
J. Eric Ivancich [Fri, 9 Feb 2024 17:27:00 +0000 (12:27 -0500)]
rgw: if head object does not have data, still include in `object manifest`

In order to enable users who might like to use `radosgw-admin object
manifest ...` to get a complete list of raw objects that comprise the
RGW object, we'll include the head object when it includes not
data. It will be indicated with an "index" of -1.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2 months agorgw: add new `object manifest` sub-command
J. Eric Ivancich [Fri, 9 Feb 2024 03:46:37 +0000 (22:46 -0500)]
rgw: add new `object manifest` sub-command

Adds a new sub-command to radosgw-admin to list the manifest, which
are the rados objects that contain the RGW object's data.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2 months agomgr/dashboard: Add RGW per user/bucket panels in grafana
Aashish Sharma [Tue, 6 Feb 2024 13:08:31 +0000 (18:38 +0530)]
mgr/dashboard: Add RGW per user/bucket panels in  grafana

Fixes: https://tracker.ceph.com/issues/64359
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2 months agoMerge pull request #53521 from xxhdx1985126/wip-62857
Kefu Chai [Fri, 9 Feb 2024 15:11:18 +0000 (23:11 +0800)]
Merge pull request #53521 from xxhdx1985126/wip-62857

crimson/osd/replicated_backend: don't put pg's metadata updates in repops

Reviewed-by: Samuel Just <sjust@redhat.com>
2 months agoMerge pull request #54650 from pereman2/buffer_map-noptr
Adam Kupczyk [Fri, 9 Feb 2024 15:07:17 +0000 (16:07 +0100)]
Merge pull request #54650 from pereman2/buffer_map-noptr

os/bluestore: use buffer values instead of pointers in buffer_map

2 months agorgw/user: add 'active' flag to RGWAccessKey
Casey Bodley [Wed, 20 Dec 2023 16:25:03 +0000 (11:25 -0500)]
rgw/user: add 'active' flag to RGWAccessKey

inactive keys are removed from the key pool so can't be used to
authenticate. the 'key create' admin op now takes an 'active' option

Fixes: https://tracker.ceph.com/issues/59186
Signed-off-by: Casey Bodley <cbodley@redhat.com>