jerasure.git
4 years agoMerge branch 'wip-signed-integer-overflow-cppcheck' into 'master' master
Loic Dachary [Mon, 10 Apr 2017 08:20:49 +0000 (08:20 +0000)]
Merge branch 'wip-signed-integer-overflow-cppcheck' into 'master'

Wip signed integer overflow cppcheck

Fix for cppcheck signed integer overflow error

See merge request !7

4 years agoResolve cppcheck Signed integer overflow error
Brad Hubbard [Mon, 10 Apr 2017 07:47:45 +0000 (17:47 +1000)]
Resolve cppcheck Signed integer overflow error

The type of expression '1<<31' is signed int and this causes cppcheck to
issue the following warning.

src/gf_w32.c:681]: (error) Signed integer overflow for expression
'1<<31'.

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
6 years agoMerge branch 'wip-documentation' into 'master'
KMG [Thu, 8 Jan 2015 14:59:33 +0000 (14:59 +0000)]
Merge branch 'wip-documentation' into 'master'

jerasure.org is http, not https

See merge request !3

6 years agojerasure.org is http, not https
Loic Dachary [Mon, 29 Dec 2014 15:47:50 +0000 (16:47 +0100)]
jerasure.org is http, not https

Also add a reference to the jerasure project @ jerasure.org

Signed-off-by: Loic Dachary <loic@dachary.org>
6 years agoMerge branch 'wip-documentation' into 'master'
KMG [Mon, 29 Dec 2014 03:25:41 +0000 (03:25 +0000)]
Merge branch 'wip-documentation' into 'master'

documentation

updates to replace URLs that do not contain useful information

See merge request !2

6 years agodocumentation: update with jerasure.org new home
Loic Dachary [Thu, 25 Dec 2014 11:23:05 +0000 (12:23 +0100)]
documentation: update with jerasure.org new home

Signed-off-by: Loic Dachary <loic@dachary.org>
6 years agoRevert "Removed PDF from the repo and added a note in the README that describes how to"
Loic Dachary [Thu, 25 Dec 2014 11:20:23 +0000 (12:20 +0100)]
Revert "Removed PDF from the repo and added a note in the README that describes how to"

This reverts commit f48b2622214084689d5a77dd290d374852e3cb29.

6 years agoMerge pull request #2 from dachary/wip-exit
kmgreen2 [Tue, 16 Dec 2014 23:07:08 +0000 (15:07 -0800)]
Merge pull request #2 from dachary/wip-exit

Merging a set of commits from Loic: Use assert(0) to exit(1) and clean-up some of the test code.

6 years agotests: add minimal encoder/decoder test 2/head
Loic Dachary [Mon, 15 Dec 2014 11:31:00 +0000 (12:31 +0100)]
tests: add minimal encoder/decoder test

Add a test to run with make check to run encoder and decoder to make
sure they work at least in one simple case. It is also useful as a
documentation about how to use them.

Signed-off-by: Loic Dachary <loic@dachary.org>
6 years agotests: fail if gf_methods is not found
Loic Dachary [Mon, 15 Dec 2014 11:29:51 +0000 (12:29 +0100)]
tests: fail if gf_methods is not found

If the gf_methods was not found, the test would silently succeed doing
nothing. Check for existence and fail if it is not in the path.

Signed-off-by: Loic Dachary <loic@dachary.org>
6 years agodecoder/encoder: fix compilation warnings
Loic Dachary [Mon, 15 Dec 2014 11:28:47 +0000 (12:28 +0100)]
decoder/encoder: fix compilation warnings

Resolve compilation warnings about unused variables and function return
values being ignored.

Signed-off-by: Loic Dachary <loic@dachary.org>
6 years agodecoder: allow for path len > 100 characters
Loic Dachary [Mon, 15 Dec 2014 11:27:17 +0000 (12:27 +0100)]
decoder: allow for path len > 100 characters

It's not that uncommon to have path longer than 100 characters.

Signed-off-by: Loic Dachary <loic@dachary.org>
6 years agouse assert(0) instead of exit(1)
Loic Dachary [Mon, 15 Dec 2014 11:08:37 +0000 (12:08 +0100)]
use assert(0) instead of exit(1)

When a fatal error (unaligned memory etc.) is detected, jerasure
should assert(3) instead of exit(3) to give a chance to the calling
program to catch the exception and display a stack trace. Although it is
possible for gdb to display the stack trace and break on exit, libraries
are not usually expected to terminate the calling program in this way.

Signed-off-by: Loic Dachary <loic@dachary.org>
6 years agoremove unused variable in tests bitbucket-master
Loic Dachary [Sat, 13 Sep 2014 21:39:24 +0000 (23:39 +0200)]
remove unused variable in tests

Signed-off-by: Loic Dachary <loic-201408@dachary.org>
6 years agodefine galois_uninit_field
Loic Dachary [Sat, 13 Sep 2014 21:15:57 +0000 (23:15 +0200)]
define galois_uninit_field

To free resources allocated by galois_init_default_field.

Signed-off-by: Loic Dachary <loic-201408@dachary.org>
7 years agoAdding option to disable SSE support in configure
Kevin Greenan [Mon, 9 Jun 2014 18:37:29 +0000 (11:37 -0700)]
Adding option to disable SSE support in configure

7 years agoRemoved PDF from the repo and added a note in the README that describes how to
Kevin Greenan [Mon, 9 Jun 2014 15:32:18 +0000 (08:32 -0700)]
Removed PDF from the repo and added a note in the README that describes how to
get the manual.

7 years agoMerged in dachary/jerasure/wip-galois-init (pull request #22)
Kevin Greenan [Sun, 8 Jun 2014 23:36:03 +0000 (16:36 -0700)]
Merged in dachary/jerasure/wip-galois-init (pull request #22)

add galois_init_default_field error code

7 years agoadd galois_init_default_field error code wip-galois-init
Loic Dachary [Sun, 8 Jun 2014 16:54:00 +0000 (18:54 +0200)]
add galois_init_default_field error code

galois_init_default_field returns an errno(3) code in case of error
instead of exiting. This is handy when the caller needs to perform
cleanup or error reporting when an error occurs instead of exit(2).

The exit(2) based error handling is preserved in the static
galois_init() function which is used in galois.c instead and is based on
galois_init_default_field to avoid code duplication.

Signed-off-by: Loic Dachary <loic@dachary.org>
7 years agoMerged in dalgaaf/jerasure/wip-da-coverity-rebase (pull request #21)
Kevin Greenan [Mon, 28 Apr 2014 18:01:10 +0000 (11:01 -0700)]
Merged in dalgaaf/jerasure/wip-da-coverity-rebase (pull request #21)

[UPDATED][Rebased #8] Fixes for SCA issues

7 years agojerasure.c: add more checks for talloc/malloc results
Danny Al-Gaaf [Sun, 27 Apr 2014 17:25:02 +0000 (19:25 +0200)]
jerasure.c: add more checks for talloc/malloc results

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
7 years agojerasure.c: add check for result of malloc()
Danny Al-Gaaf [Sun, 27 Apr 2014 16:54:21 +0000 (18:54 +0200)]
jerasure.c: add check for result of malloc()

Add check for bitmatrix and return NULL if malloc failed.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
7 years agojerasure.c: free memory before return in error case
Danny Al-Gaaf [Sat, 22 Mar 2014 20:58:53 +0000 (21:58 +0100)]
jerasure.c: free memory before return in error case

Fix for Coverity issue from Ceph project:

CID 1093211 (#1 of 1): Resource leak (RESOURCE_LEAK)
 20. leaked_storage: Variable "ind_to_row" going out of scope leaks
 the storage it points to.

CID 1093212 (#1 of 1): Resource leak (RESOURCE_LEAK)
 20. leaked_storage: Variable "row_ids" going out of scope leaks the
 storage it points to.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
7 years agoExamples/*coder.c: add missing include of unistd.h
Danny Al-Gaaf [Sat, 22 Mar 2014 22:46:51 +0000 (23:46 +0100)]
Examples/*coder.c: add missing include of unistd.h

Fix warning: implicit declaration of function 'getcwd' is invalid in
C99 [-Wimplicit-function-declaration]

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
7 years agoExamples/reed_sol_time_gf.c: include sys/time.h
Danny Al-Gaaf [Sat, 22 Mar 2014 22:38:48 +0000 (23:38 +0100)]
Examples/reed_sol_time_gf.c: include sys/time.h

Fix warning: implicit declaration of function 'gettimeofday' is
invalid in C99 [-Wimplicit-function-declaration]

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
7 years agojerasure.c: fix memory leak in error case
Danny Al-Gaaf [Sat, 22 Mar 2014 21:08:06 +0000 (22:08 +0100)]
jerasure.c: fix memory leak in error case

Check matrix for NULL before call talloc().

CID 1093213 (#1 of 1): Resource leak (RESOURCE_LEAK)
 4. leaked_storage: Variable "bitmatrix" going out of scope
 leaks the storage it points to.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
7 years agoMerged in dachary/jerasure/wip-init (pull request #17)
Kevin Greenan [Tue, 8 Apr 2014 22:57:55 +0000 (15:57 -0700)]
Merged in dachary/jerasure/wip-init (pull request #17)

make galois_init_default_field(int w) extern

7 years agomake galois_init_default_field(int w) extern
Loic Dachary [Tue, 8 Apr 2014 22:05:18 +0000 (00:05 +0200)]
make galois_init_default_field(int w) extern

So that the application can initialize gfp_array and gfp_is_composite
instead of relying on initialization happening implicitly when the
multiply or xor functions are called. The init function can be called
once when the application guarantees thread safety. And the multiply and
xor functions can be called from multiple threads without risking races.

Signed-off-by: Loic Dachary <loic@dachary.org>
7 years agoMerged in dachary/jerasure/wip-make-check (pull request #16)
Kevin Greenan [Thu, 3 Apr 2014 23:39:03 +0000 (16:39 -0700)]
Merged in dachary/jerasure/wip-make-check (pull request #16)

run tests with make check

7 years agoMerged in dwglessner/jerasure/pull-#9-cleanup (pull request #15)
Kevin Greenan [Thu, 3 Apr 2014 23:17:13 +0000 (16:17 -0700)]
Merged in dwglessner/jerasure/pull-#9-cleanup (pull request #15)

AM_CFLAGS and typo cleanup

7 years agorun tests with make check
Loic Dachary [Wed, 2 Apr 2014 16:22:53 +0000 (18:22 +0200)]
run tests with make check

* Update the README accordingly
* Add the VALGRIND variable to run thru valgrind where possible
* Add the make check files administrative files to .gitignore

Signed-off-by: Loic Dachary <loic@dachary.org>
7 years agoFix typo about Autoconf >= 2.65 requirement.
David Glessner [Sat, 29 Mar 2014 03:14:58 +0000 (22:14 -0500)]
Fix typo about Autoconf >= 2.65 requirement.

7 years agoRemove -O3, -fPIC, $(INCLUDES) from AM_CFLAGS.
David Glessner [Sat, 29 Mar 2014 03:13:18 +0000 (22:13 -0500)]
Remove -O3, -fPIC, $(INCLUDES) from AM_CFLAGS.

They aren't needed, and can be harmful if they override user selection.

7 years agoMerged in dachary/jerasure/wip-gf-complete-tests (pull request #12)
Kevin Greenan [Mon, 31 Mar 2014 15:59:50 +0000 (08:59 -0700)]
Merged in dachary/jerasure/wip-gf-complete-tests (pull request #12)

allow override of GF-Complete directory in test_all_gfs.sh

7 years agoMerged in dachary/jerasure/wip-warning-unused (pull request #14)
Kevin Greenan [Mon, 31 Mar 2014 15:22:43 +0000 (08:22 -0700)]
Merged in dachary/jerasure/wip-warning-unused (pull request #14)

silence warning about bestrow used uninitialized

7 years agosilence warning about bestrow used uninitialized
Loic Dachary [Sun, 30 Mar 2014 08:55:46 +0000 (10:55 +0200)]
silence warning about bestrow used uninitialized

Signed-off-by: Loic Dachary <loic@dachary.org>
7 years agoMerged in dachary/jerasure/wip-gitignore (pull request #11)
Kevin Greenan [Sat, 29 Mar 2014 15:44:58 +0000 (08:44 -0700)]
Merged in dachary/jerasure/wip-gitignore (pull request #11)

add .dirstamp to gitignore

7 years agoallow override of GF-Complete directory in test_all_gfs.sh
Loic Dachary [Sat, 29 Mar 2014 08:29:34 +0000 (09:29 +0100)]
allow override of GF-Complete directory in test_all_gfs.sh

And document how to run it in the README

Signed-off-by: Loic Dachary <loic@dachary.org>
7 years agoadd .dirstamp to gitignore
Loic Dachary [Fri, 28 Mar 2014 16:39:53 +0000 (17:39 +0100)]
add .dirstamp to gitignore

Signed-off-by: Loic Dachary <loic@dachary.org>
7 years agoThis is the squashed pull request from David Glessner, squashed
David Glessner [Sat, 8 Mar 2014 19:08:36 +0000 (13:08 -0600)]
This is the squashed pull request from David Glessner, squashed
and reviewed by Kevin Greenan.

Updated README

Allow out-of-source builds. Quiet autogen.sh warnings.

Use AM_CPPFLAGS instead of INCLUDES. Use $(top_srcdir).

Add .gitignore to quiet git status.

Add project URL to AC_INIT.

Stop libtool from compiling files twice.

Have git ignore .deps/.

Don't override user CPPFLAGS.

(PIC options appear to be set already. INCLUDES already included.)

Clean configure.ac.

Make it closer to autoscan output.

Have autotools create INSTALL.

Use AC_MSG_FAILURE if GF-Complete not found.

Run autogen.sh.

(autoconf 2.69, automake 1.14.1, libtool 2.4.2)

Add some .gitignore files.

Fix configure cpuid unknown issue.

Move AX_EXT before AC_CHECK_LIB(gf_complete...) so that
-lgf_complete doesn't cause CPUID conftest compile to fail.

Don't check for internal gf_int.h header.

GF-Complete doesn't install it.

Quiet some autoreconf warnings.

INCLUDES is now AM_CPPFLAGS. Use single-argument AM_INIT_AUTOMAKE.

Remove some AC_REQUIRE whose conftest always failed.

Quiet configure warning.

(ARCH_64 doesn't appear to be used.)

CPUID "unknown" fix from upstream autoconf-archive.

Allow out-of-source builds. Use dependency tracking.

Remove config.h.in~.

Update ax_check_compile_flag.m4 from autoconf-archive.

Add .gitattributes.

Remove autoreconf-generated files.

Remove ACLOCAL_AMFLAGS.

See Automake 1.13 release notes.

Add files for 'make dist'.

Quiet some warnings.

getcwd() in <unistd.h>. Remove some vars.

Make headers compatible with C++.

Quiet some warnings.

Install additional headers in include/jerasure/.

Quiet some configure check internal failures.

Use new AX_REQUIRE_DEFINED instead of AC_REQUIRE, which expands
the macro and causes internal compile failure.

Fix file permissions.

Remove INTEL_SSE compiler defines.

(Can use HAVE_xxx or __xxx__ instead.)

Set default CFLAGS to '-g -O3 -Wall'.

Add more checks from autoscan.

Use AC_CONFIG_AUX_DIR([build-aux]).

Use processor time for timing.

Use clock() instead of gettimeofday().

Use common LDADD in Makefile.am.

Remove pre-autotools makefiles.

Ignore *.a. (Missed earlier.)

Quiet more warnings.

Document need for autoreconf -fi.

Removed README.nd and README.txt so changes don't need to be duplicated.

Remove autogen.sh.

Just use "autoreconf --force --install".

7 years agoQuiet configure warning.
David Glessner [Sat, 8 Mar 2014 18:59:52 +0000 (12:59 -0600)]
Quiet configure warning.

(ARCH_64 doesn't appear to be used.)

7 years agoMerged in dachary/jerasure/wip-compilation-warnings (pull request #2)
James Plank [Thu, 6 Mar 2014 03:12:44 +0000 (22:12 -0500)]
Merged in dachary/jerasure/wip-compilation-warnings (pull request #2)

fix compilation warnings

7 years agoadd missing return value to functions that require it
Loic Dachary [Thu, 6 Mar 2014 00:29:12 +0000 (01:29 +0100)]
add missing return value to functions that require it

Signed-off-by: Loic Dachary <loic@dachary.org>
7 years agoremove unused variables
Loic Dachary [Thu, 6 Mar 2014 00:28:35 +0000 (01:28 +0100)]
remove unused variables

Signed-off-by: Loic Dachary <loic@dachary.org>
7 years agoFixed some compiler warnings.
Jim Plank [Fri, 7 Feb 2014 17:12:54 +0000 (12:12 -0500)]
Fixed some compiler warnings.

7 years agoAdded compilation instructions for when you don't have GF-Complete
Jim Plank [Fri, 7 Feb 2014 16:39:19 +0000 (11:39 -0500)]
Added compilation instructions for when you don't have GF-Complete
installed as root.

7 years agoAdded the user manual PDF to Manual.pdf
Jim Plank [Wed, 29 Jan 2014 21:39:29 +0000 (16:39 -0500)]
Added the user manual PDF to Manual.pdf

7 years agoMore formatting.
Jim Plank [Wed, 29 Jan 2014 21:35:36 +0000 (16:35 -0500)]
More formatting.

7 years agoFormatting.
Jim Plank [Wed, 29 Jan 2014 21:08:53 +0000 (16:08 -0500)]
Formatting.

7 years agoAdded the user's manual.
Jim Plank [Wed, 29 Jan 2014 20:56:05 +0000 (15:56 -0500)]
Added the user's manual.

7 years agoMerged in kmgreen2/jerasure-kmg (pull request #1)
James Plank [Sat, 25 Jan 2014 15:58:24 +0000 (10:58 -0500)]
Merged in kmgreen2/jerasure-kmg (pull request #1)

Time to update to jerasure 2.0

7 years agoRevision 2.0 is ready for prime time!
Jim Plank [Sat, 25 Jan 2014 15:55:29 +0000 (10:55 -0500)]
Revision 2.0 is ready for prime time!

7 years agoNeeded .txt
Jim Plank [Fri, 24 Jan 2014 21:54:20 +0000 (16:54 -0500)]
Needed .txt

7 years agoMaking sure ht enew readme is there.
Jim Plank [Fri, 24 Jan 2014 21:53:09 +0000 (16:53 -0500)]
Making sure ht enew readme is there.

7 years agoRan through all of the examples to make them current. I'll have to
Jim Plank [Fri, 24 Jan 2014 21:50:41 +0000 (16:50 -0500)]
Ran through all of the examples to make them current.  I'll have to
do another sanity-checking pass, and fix multby_2 in the reed_sol code,
but then we're done.

7 years agoMake autoconf put BSD license in COPYING.
Kevin Greenan [Tue, 7 Jan 2014 16:40:05 +0000 (08:40 -0800)]
Make autoconf put BSD license in COPYING.

7 years agoMinor typos and stuff. More later.
Jim Plank [Wed, 1 Jan 2014 20:02:19 +0000 (15:02 -0500)]
Minor typos and stuff.  More later.

7 years agoAdded code to not use gf-complete mult_by_one if region size is small (less than...
Kevin Greenan [Sat, 28 Dec 2013 04:55:04 +0000 (20:55 -0800)]
Added code to not use gf-complete mult_by_one if region size is small (less than 16 bytes).

7 years agoDo SIMD XOR, where possible!
Kevin Greenan [Fri, 20 Dec 2013 16:21:46 +0000 (08:21 -0800)]
Do SIMD XOR, where possible!

7 years agoFix README(s)
Kevin Greenan [Thu, 5 Dec 2013 07:11:15 +0000 (23:11 -0800)]
Fix README(s)

7 years agoSetup autoconf to work with Jerasure
Kevin Greenan [Thu, 5 Dec 2013 06:56:31 +0000 (22:56 -0800)]
Setup autoconf to work with Jerasure

7 years agoAdded performance numbers and more text to the README
Kevin Greenan [Mon, 25 Nov 2013 02:40:05 +0000 (18:40 -0800)]
Added performance numbers and more text to the README

7 years agoAdded tests for the GF init helper functions in galois.c
Kevin Greenan [Sun, 24 Nov 2013 21:20:21 +0000 (13:20 -0800)]
Added tests for the GF init helper functions in galois.c

Updated the README to explain the GF change procedure.

7 years agoError handling fixed in test scripts...
Kevin Greenan [Sat, 23 Nov 2013 20:18:29 +0000 (12:18 -0800)]
Error handling fixed in test scripts...

7 years agoAdded new license header for version 2.0
Kevin Greenan [Sat, 23 Nov 2013 19:51:25 +0000 (11:51 -0800)]
Added new license header for version 2.0

Updated the README (Going to add detail on how to us GF-complete soon)

7 years agoRe-org and re-named some stuff...
Kevin Greenan [Sat, 23 Nov 2013 18:35:28 +0000 (10:35 -0800)]
Re-org and re-named some stuff...

7 years agoClean-up and use of aligned buffers in Test/
Kevin Greenan [Tue, 19 Nov 2013 06:17:05 +0000 (22:17 -0800)]
Clean-up and use of aligned buffers in Test/

All of the new tests appear to pass.

7 years agoMake sure tests always grab aligned buffers (use valloc instead of malloc).
Kevin Greenan [Tue, 19 Nov 2013 05:13:59 +0000 (21:13 -0800)]
Make sure tests always grab aligned buffers (use valloc instead of malloc).

7 years agoMove 'install' to $(INCDIR) instead of $(INCDIR)/jerasure
Kevin Greenan [Sat, 19 Oct 2013 14:40:57 +0000 (07:40 -0700)]
Move 'install' to $(INCDIR) instead of $(INCDIR)/jerasure

7 years agojerasure: Add -fPIC to CFLAGS
Tushar Gohad [Wed, 16 Oct 2013 02:28:24 +0000 (19:28 -0700)]
jerasure: Add -fPIC to CFLAGS

Signed-off-by: Tushar Gohad <tsg@swiftdev.(none)>
7 years agoAdded some performance tests, set the default GF for w=16 to SPLIT 16,4
Kevin Greenan [Wed, 16 Oct 2013 16:09:02 +0000 (09:09 -0700)]
Added some performance tests, set the default GF for w=16 to SPLIT 16,4
and created function for autoconf to call during configure (spot check).

7 years agoIncorporated more of GF-Complete and added some tests...
Kevin Greenan [Sat, 12 Oct 2013 05:47:23 +0000 (22:47 -0700)]
Incorporated more of GF-Complete and added some tests...

7 years agomakefile works on Darwin and Linux
Kevin Greenan [Sat, 12 Oct 2013 02:47:49 +0000 (19:47 -0700)]
makefile works on Darwin and Linux

7 years agoFirst (crude) pass at hooking GF-Complete into Jerasure. Just enough to do some...
Kevin Greenan [Tue, 8 Oct 2013 06:07:29 +0000 (23:07 -0700)]
First (crude) pass at hooking GF-Complete into Jerasure.  Just enough to do some testing before
doing the actual wiring.

7 years agoCharacter counting bug.
Jim Plank [Tue, 1 Oct 2013 17:26:24 +0000 (13:26 -0400)]
Character counting bug.

7 years agoAdding the current jerasure 1.2A
Jim Plank [Tue, 1 Oct 2013 17:25:12 +0000 (13:25 -0400)]
Adding the current jerasure 1.2A