]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
mgr/PyModule: correctly remove config options
authorTim Serong <tserong@suse.com>
Fri, 22 Nov 2019 09:25:19 +0000 (20:25 +1100)
committerTim Serong <tserong@suse.com>
Fri, 22 Nov 2019 12:25:33 +0000 (23:25 +1100)
commit0520ff571cfb480872c8bd429c94bd4ce15eeb40
treee4863c97e924f84bb6b4ddbb7a3412541fcbd591
parent4c3127d28279510a5117bd5ab11374ad3f5559d4
mgr/PyModule: correctly remove config options

Previously, incorrect parameters were being passed to "config rm",
causing it to do nothing.  This commit also ensures the correct
error message is shown for both the set and remove failure cases.
I've also moved the update of the in-memory config map to *after*
the value is persisted, to ensure the config map actually reflects
what's stored.

Fixes: https://tracker.ceph.com/issues/42958
Signed-off-by: Tim Serong <tserong@suse.com>
src/mgr/PyModule.cc