]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Fix NotifyOnFlushCompleted() for atomic flush (#8585)
authorYanqin Jin <yanqin@fb.com>
Tue, 3 Aug 2021 20:30:05 +0000 (13:30 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Tue, 3 Aug 2021 20:31:10 +0000 (13:31 -0700)
commit0879c240404b00142ba4718f36cd3f2bd537192d
tree98f2fb613ce7ef351d1c21a998cc2e05120b6910
parent8b2f60b668cfde8a5845f00648d8b4da3a873164
Fix NotifyOnFlushCompleted() for atomic flush (#8585)

Summary:
PR https://github.com/facebook/rocksdb/issues/5908 added `flush_jobs_info_` to `FlushJob` to make sure
`OnFlushCompleted()` is called after committing flush results to
MANIFEST. However, `flush_jobs_info_` is not updated in atomic
flush, causing `NotifyOnFlushCompleted()` to skip `OnFlushCompleted()`.

This PR fixes this, in a similar way to https://github.com/facebook/rocksdb/issues/5908 that handles regular flush.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/8585

Test Plan: make check

Reviewed By: jay-zhuang

Differential Revision: D29913720

Pulled By: riversand963

fbshipit-source-id: 4ff023c98372fa2c93188d4a5c8a4e9ffa0f4dda
db/db_impl/db_impl_compaction_flush.cc
db/flush_job_test.cc
db/listener_test.cc
db/memtable_list.cc
db/memtable_list.h
db/memtable_list_test.cc