]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Fix StallWrite crash with mixed of slowdown/no_slowdown writes (#7508)
authorJay Zhuang <zjay@fb.com>
Tue, 6 Oct 2020 19:42:57 +0000 (12:42 -0700)
committerJay Zhuang <zjay@fb.com>
Wed, 14 Oct 2020 00:44:02 +0000 (17:44 -0700)
commit0bda0e3dfaf27ac3b0ecbfd24dfe80689bd2aa67
tree8d0ab9b4403ae842b43222450815d21c1bcd2064
parent950b72c7430e36aab6a37ef81f0bf779901fd68a
Fix StallWrite crash with mixed of slowdown/no_slowdown writes (#7508)

Summary:
`BeginWriteStall()` removes no_slowdown write from the write
list and updates `link_newer`, which makes `CreateMissingNewerLinks()`
thought all write list has valid `link_newer` and failed to create link
for all writers.
It caused flaky test and SegFault for release build.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/7508

Test Plan: Add unittest to reproduce the issue.

Reviewed By: anand1976

Differential Revision: D24126601

Pulled By: jay-zhuang

fbshipit-source-id: f8ac5dba653f7ee1b0950296427d4f5f8ee34a06
HISTORY.md
db/db_impl/db_impl_write.cc
db/db_write_test.cc
db/write_thread.cc