]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Fix SIGSEGV in compaction picker
authorIgor Canadi <icanadi@fb.com>
Fri, 17 Jan 2014 20:02:03 +0000 (12:02 -0800)
committerIgor Canadi <icanadi@fb.com>
Fri, 17 Jan 2014 20:02:03 +0000 (12:02 -0800)
commit0f4a75b710d616b08a06321ae29979d05cbf1f76
tree7f046026dade06f165446a53df72685161cd3bcb
parent439e36db21ca3ac637fce484c39601f402f1056c
Fix SIGSEGV in compaction picker

Summary:
The SIGSEGV was introduced by https://reviews.facebook.net/D15171

I also fixed ExpandWhileOverlapping() which returned the failure by setting it's own stack variable to nullptr (!). This bug is present in 2.6 release, so I guess ExpandWhileOverlapping never fails :)

Test Plan: `make check`. Also MarkCallaghan confirmed it fixed the SIGSEGV he reported.

Reviewers: MarkCallaghan, kailiu, sdong, dhruba, haobo

Reviewed By: kailiu

CC: leveldb
Differential Revision: https://reviews.facebook.net/D15261
db/compaction_picker.cc
db/compaction_picker.h