]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commit
PCI: use generic driver_override infrastructure
authorDanilo Krummrich <dakr@kernel.org>
Tue, 24 Mar 2026 00:59:09 +0000 (01:59 +0100)
committerDanilo Krummrich <dakr@kernel.org>
Fri, 3 Apr 2026 22:44:30 +0000 (00:44 +0200)
commit10a4206a24013be4d558d476010cbf2eb4c9fa64
treee79b7e424d5f031f6cc9768e18878bd18e115dbb
parent1cf996ac307e4d8d86f07d72b55528df88b56ce6
PCI: use generic driver_override infrastructure

When a driver is probed through __driver_attach(), the bus' match()
callback is called without the device lock held, thus accessing the
driver_override field without a lock, which can cause a UAF.

Fix this by using the driver-core driver_override infrastructure taking
care of proper locking internally.

Note that calling match() from __driver_attach() without the device lock
held is intentional. [1]

Link: https://lore.kernel.org/driver-core/DGRGTIRHA62X.3RY09D9SOK77P@kernel.org/
Reported-by: Gui-Dong Han <hanguidong02@gmail.com>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220789
Fixes: 782a985d7af2 ("PCI: Introduce new device binding path using pci_dev.driver_override")
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Alex Williamson <alex@shazbot.org>
Tested-by: Gui-Dong Han <hanguidong02@gmail.com>
Reviewed-by: Gui-Dong Han <hanguidong02@gmail.com>
Link: https://patch.msgid.link/20260324005919.2408620-6-dakr@kernel.org
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
drivers/pci/pci-driver.c
drivers/pci/pci-sysfs.c
drivers/pci/probe.c
drivers/vfio/pci/vfio_pci_core.c
drivers/xen/xen-pciback/pci_stub.c
include/linux/pci.h