]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commit
spi: rockchip-sfc: Fix double-free in remove() callback
authorFelix Gu <ustc.gu@gmail.com>
Mon, 9 Mar 2026 18:01:34 +0000 (02:01 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 9 Mar 2026 19:10:21 +0000 (19:10 +0000)
commit111e2863372c322e836e0c896f6dd9cf4ee08c71
treeccaf251bc715844143f73cd558a9b4f523821246
parentad0e9ac2d5f5ab7a773c2c07ecf06ee59db9259f
spi: rockchip-sfc: Fix double-free in remove() callback

The driver uses devm_spi_register_controller() for registration, which
automatically unregisters the controller via devm cleanup when the
device is removed. The manual call to spi_unregister_controller() in
the remove() callback can lead to a double-free.

And to make sure controller is unregistered before DMA buffer is
unmapped, switch to use spi_register_controller() in probe().

Fixes: 8011709906d0 ("spi: rockchip-sfc: Support pm ops")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Link: https://patch.msgid.link/20260310-sfc-v2-1-67fab04b097f@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-rockchip-sfc.c