]> git.apps.os.sepia.ceph.com Git - ceph-client.git/commit
hwmon: mlxreg-fan: Prevent fans from getting stuck at 0 RPM
authorVadim Pasternak <vadimp@nvidia.com>
Wed, 30 Jul 2025 20:17:15 +0000 (23:17 +0300)
committerGuenter Roeck <linux@roeck-us.net>
Fri, 29 Aug 2025 13:55:58 +0000 (06:55 -0700)
commit1180c79fbf36e4c02e76ae4658509523437e52a4
treeb7ef36f0d6475eb9a4299936c0e8c64a922a139f
parent1b237f190eb3d36f52dffe07a40b5eb210280e00
hwmon: mlxreg-fan: Prevent fans from getting stuck at 0 RPM

The fans controlled by the driver can get stuck at 0 RPM if they are
configured below a 20% duty cycle. The driver tries to avoid this by
enforcing a minimum duty cycle of 20%, but this is done after the fans
are registered with the thermal subsystem. This is too late as the
thermal subsystem can set their current state before the driver is able
to enforce the minimum duty cycle.

Fix by setting the minimum duty cycle before registering the fans with
the thermal subsystem.

Fixes: d7efb2ebc7b3 ("hwmon: (mlxreg-fan) Extend driver to support multiply cooling devices")
Reported-by: Nikolay Aleksandrov <razor@blackwall.org>
Tested-by: Nikolay Aleksandrov <razor@blackwall.org>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
Link: https://lore.kernel.org/r/20250730201715.1111133-1-vadimp@nvidia.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/mlxreg-fan.c