]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
rgw: sanitize newlines in s3 CORSConfiguration's ExposeHeader
authorCasey Bodley <cbodley@redhat.com>
Tue, 26 May 2020 19:03:03 +0000 (15:03 -0400)
committerAbhishek Lekshmanan <abhishek@suse.com>
Thu, 25 Jun 2020 12:02:02 +0000 (14:02 +0200)
commit1524d3c0c5cb11775313ea1e2bb36a93257947f2
tree9eb3d760b8bfaeb7b5568c008d7b8384ea911f1c
parent0e76c3a743f48167b56de1f9e5b428a0a16f9532
rgw: sanitize newlines in s3 CORSConfiguration's ExposeHeader

the values in the <ExposeHeader> element are sent back to clients in a
Access-Control-Expose-Headers response header. if the values are allowed
to have newlines in them, they can be used to inject arbitrary response
headers

this issue only affects s3, which gets these values from an xml document

in swift, they're given in the request header
X-Container-Meta-Access-Control-Expose-Headers, so the value itself
cannot contain newlines

Signed-off-by: Casey Bodley <cbodley@redhat.com>
Reported-by: Adam Mohammed <amohammed@linode.com>
src/rgw/rgw_cors.cc