]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ansible.git/commit
rolling_update: stop/start instead of restart
authorDimitri Savineau <dsavinea@redhat.com>
Tue, 21 Jul 2020 18:51:20 +0000 (14:51 -0400)
committerGuillaume Abrioux <gabrioux@redhat.com>
Sat, 25 Jul 2020 07:35:17 +0000 (09:35 +0200)
commit155e2a23d54ea29ccbf5414cb93cdc748c516e79
tree39996f6f5c029ce8dd8de4ab57fb6fea39b20fd0
parent4e84b4beedc54b94c0263212a926a1919c329b91
rolling_update: stop/start instead of restart

During the daemon upgrade we're
  - stopping the service when it's not containerized
  - running the daemon role
  - start the service when it's not containerized
  - restart the service when it's containerized

This implementation has multiple issue.

1/ We don't use the same service workflow when using containers
or baremetal.

2/ The explicity daemon start isn't required since we'are already
doing this in the daemon role.

3/ Any non backward changes in the systemd unit template (for
containerized deployment) won't work due to the restart usage.

This patch refacts the rolling_update playbook by using the same service
stop task for both containerized and baremetal deployment at the start
of the upgrade play.
It removes the explicit service start task because it's already included
in the dedicated role.
The service restart tasks for containerized deployment are also
removed.

Finally, this adds the missing service stop task for ceph crash upgrade
workflow.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1859173
Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
infrastructure-playbooks/rolling_update.yml