]> git.apps.os.sepia.ceph.com Git - ceph-ansible.git/commit
rolling_update: stop/start instead of restart
authorDimitri Savineau <dsavinea@redhat.com>
Tue, 21 Jul 2020 18:51:20 +0000 (14:51 -0400)
committerDimitri Savineau <savineau.dimitri@gmail.com>
Mon, 27 Jul 2020 13:43:01 +0000 (09:43 -0400)
commit15872e3db1e342238636bc9c8e1aef6bd1d3dcd8
treedb3adbab8611aec84d8f8f6e2cd5ecdad365d776
parentcce042c65b7d59ff433d0d3d80f8d5c096223c50
rolling_update: stop/start instead of restart

During the daemon upgrade we're
  - stopping the service when it's not containerized
  - running the daemon role
  - start the service when it's not containerized
  - restart the service when it's containerized

This implementation has multiple issue.

1/ We don't use the same service workflow when using containers
or baremetal.

2/ The explicity daemon start isn't required since we'are already
doing this in the daemon role.

3/ Any non backward changes in the systemd unit template (for
containerized deployment) won't work due to the restart usage.

This patch refacts the rolling_update playbook by using the same service
stop task for both containerized and baremetal deployment at the start
of the upgrade play.
It removes the explicit service start task because it's already included
in the dedicated role.
The service restart tasks for containerized deployment are also
removed.

This following comment isn't valid because we should have backported
ceph-crash implementation in stable-4.0 before this commit, which was not
possible because of the needed tag v4.0.25.1 (async release for 4.1z1):

~~Finally, this adds the missing service stop task for ceph crash upgrade
workflow.~~

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1859173
Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
(cherry picked from commit 155e2a23d54ea29ccbf5414cb93cdc748c516e79)
infrastructure-playbooks/rolling_update.yml