]> git.apps.os.sepia.ceph.com Git - xfstests-dev.git/commit
xfstests: loop devices vs umount stupidity
authorDave Chinner <dchinner@redhat.com>
Thu, 26 Jul 2012 08:35:04 +0000 (08:35 +0000)
committerroot <root@cxfsxe4.(none)>
Wed, 22 Aug 2012 20:50:46 +0000 (15:50 -0500)
commit1670bd4f3419d23f7892db0244eb153642771509
treef626bec8e16ec6ccfa926b125d8647705b667ed3
parent427249fe4a933f46d51aee6b057af77dbaba748c
xfstests: loop devices vs umount stupidity

Unmounting a fileystem mounted on a loop device doesn't always tear
down the loop device. Its racy, and it causes tests to randomly
fail.

To avoid that, we have to use umount -d to ensure that we destroy
loop devices under filesystems in case the kernel doesn't tear it
down automatically to prevent the test from failing.  However, if
the kernel does tear it down automatically, umount now issues a
warning that it couldn't tear down the loop device because it
couldn't find it, and that causes the test to fail. *facepalm*

So, convert all the loop device unmounts to use -d, and direct the
output of all of them to /dev/null.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Rich Johnston <rjohnston@sgi.com>
Signed-off-by: Rich Johnston <rjohnston@sgi.com>
049
073
078
216
217
250