]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
crimson/mon: actually skip CEPHX_V2 authorizer challenges when needed
authorIlya Dryomov <idryomov@gmail.com>
Sat, 17 Oct 2020 09:12:16 +0000 (11:12 +0200)
committerIlya Dryomov <idryomov@gmail.com>
Tue, 20 Oct 2020 13:58:43 +0000 (15:58 +0200)
commit16cf4cc062adcb4094ae4c9beca485791e290667
tree24a7701d89e043f6f69490df995b47fee05efadd
parentd0036dbe3ef2aba531a06b56d87024c9554f5ff9
crimson/mon: actually skip CEPHX_V2 authorizer challenges when needed

When commit 321548010578 ("mon/MonClient: skip CEPHX_V2 challenge
if client doesn't support it") was being ported to crimson, it got
adjusted incorrectly (but rather fortunately).  While the original
always skips authorizer challenges, the port almost never skips
them.  This is because it looks at the features of the monitor that
crimson-osd is connected to instead of the features of the peer that
is trying to authenticate.  As a result, msgr1 peer would get the
challenge even if it legitimately doesn't support CEPHX_V2 and fault
on an unknown protocol tag.

To fix, port commit 4a82c72e3bdd ("mon/MonClient: bring back CEPHX_V2
authorizer challenges").

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
src/crimson/mon/MonClient.cc
src/crimson/net/ProtocolV1.cc