]> git.apps.os.sepia.ceph.com Git - ceph-client.git/commit
Revert "drm/tegra: Use dma_buf from GEM object instance"
authorThomas Zimmermann <tzimmermann@suse.de>
Tue, 15 Jul 2025 08:45:39 +0000 (10:45 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Tue, 26 Aug 2025 08:41:27 +0000 (10:41 +0200)
commit16fdb3cc6af8460f23a706512c6f5e7dfdd4f338
tree095f7ea95786aba619a23a4cdae2bfe2e7493156
parente228e7d382fa85005ee2ebf303e1bf194aca49a8
Revert "drm/tegra: Use dma_buf from GEM object instance"

This reverts commit 482c7e296edc0f594e8869a789a40be53c49bd6a.

The dma_buf field in struct drm_gem_object is not stable over the
object instance's lifetime. The field becomes NULL when user space
releases the final GEM handle on the buffer object. This resulted
in a NULL-pointer deref.

Workarounds in commit 5307dce878d4 ("drm/gem: Acquire references on
GEM handles for framebuffers") and commit f6bfc9afc751 ("drm/framebuffer:
Acquire internal references on GEM handles") only solved the problem
partially. They especially don't work for buffer objects without a DRM
framebuffer associated.

Hence, this revert to going back to using .import_attach->dmabuf.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Simona Vetter <simona.vetter@ffwll.ch>
Link: https://lore.kernel.org/r/20250715084549.41473-1-tzimmermann@suse.de
drivers/gpu/drm/tegra/gem.c