]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Fix a bug in file ingestion (#5760)
authorYanqin Jin <yanqin@fb.com>
Sat, 31 Aug 2019 01:27:43 +0000 (18:27 -0700)
committerYanqin Jin <yanqin@fb.com>
Tue, 3 Sep 2019 20:05:22 +0000 (13:05 -0700)
commit17a3c25564be0fb145a10fc431bd4758e7665344
treecfdb5735b7baef3d988ae606e7e9603c7563e0b7
parent4ff493bb38e951a59150601cd2ee3ff225df2862
Fix a bug in file ingestion (#5760)

Summary:
Before this PR, when the number of column families involved in a file ingestion exceeds 2, a bug in the looping logic prevents correct file number being assigned to each ingestion job.
Also skip deleting non-existing hard links during cleanup-after-failure.

Test plan (devserver)
```
$COMPILE_WITH_ASAN=1 make all
$./external_sst_file_test --gtest_filter=ExternalSSTFileTest/ExternalSSTFileTest.IngestFilesIntoMultipleColumnFamilies_*/*
$makke check
```
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5760

Differential Revision: D17142982

Pulled By: riversand963

fbshipit-source-id: 06c1847a4e7a402647bcf28d124e70f2a0f9daf6
HISTORY.md
db/db_impl/db_impl.cc
db/external_sst_file_ingestion_job.cc
db/external_sst_file_test.cc