]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commit
rbd: don't bother setting snapid in rbd_do_request()
authorAlex Elder <elder@inktank.com>
Fri, 9 Nov 2012 18:50:10 +0000 (12:50 -0600)
committerAlex Elder <elder@inktank.com>
Mon, 19 Nov 2012 23:37:49 +0000 (17:37 -0600)
commit19767569994cd39ac27b5f8df2eec85dbb40bd35
treed6be9b8b1cf80f3863e72c78c449e89ff4881d30
parent2110047b48aab4e71f17ba5f0c2aef34754e3452
rbd: don't bother setting snapid in rbd_do_request()

For some reason, the snapid field of the osd request header is
explicitly set to CEPH_NOSNAP in rbd_do_request().  Just a few lines
later--with no code that would access this field in between--a call
is made to ceph_calc_raw_layout() passing the snapid provided to
rbd_do_request(), which encodes the snapid value it is provided into
that field instead.

In other words, there is no need to fill in CEPH_NOSNAP, and doing
so suggests it might be necessary.  Don't do that any more.

Signed-off-by: Alex Elder <elder@inktank.com>
drivers/block/rbd.c