]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commit
workqueue: devres: Add device-managed allocate workqueue
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Thu, 5 Mar 2026 21:45:40 +0000 (22:45 +0100)
committerTejun Heo <tj@kernel.org>
Tue, 10 Mar 2026 17:03:39 +0000 (07:03 -1000)
commit1dfc9d60a69ec148e1cb709256617d86e5f0e8f8
tree37a33b165b996e347e0b3b9364a8fde20f78b57f
parent6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
workqueue: devres: Add device-managed allocate workqueue

Add a Resource-managed version of alloc_workqueue() to fix common
problem of drivers mixing devm() calls with destroy_workqueue.  Such
naive and discouraged driver approach leads to difficult to debug bugs
when the driver:

1. Allocates workqueue in standard way and destroys it in driver
   remove() callback,
2. Sets work struct with devm_work_autocancel(),
3. Registers interrupt handler with devm_request_threaded_irq().

Which leads to following unbind/removal path:

1. destroy_workqueue() via driver remove(),
   Any interrupt coming now would still execute the interrupt handler,
   which queues work on destroyed workqueue.
2. devm_irq_release(),
3. devm_work_drop() -> cancel_work_sync() on destroyed workqueue.

devm_alloc_workqueue() has two benefits:
1. Solves above problem of mix-and-match devres and non-devres code in
   driver,
2. Simplify any sane drivers which were correctly using
   alloc_workqueue() + devm_add_action_or_reset().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Acked-by: Tejun Heo <tj@kernel.org>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Documentation/driver-api/driver-model/devres.rst
include/linux/workqueue.h
kernel/workqueue.c