]> git.apps.os.sepia.ceph.com Git - xfsprogs-dev.git/commit
xfs_scrub: fix erroring out of check_inode_names
authorDarrick J. Wong <djwong@kernel.org>
Mon, 29 Jul 2024 23:23:28 +0000 (16:23 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Tue, 30 Jul 2024 00:01:13 +0000 (17:01 -0700)
commit1fe7d5ef7a0b47e375f7a51d502f574f9ad8811a
tree2b8e078b19cc4f57d1e865791dc3abfc64e63882
parent9eea3288aed85b06d13a682f8f79e1fa6e2ce71c
xfs_scrub: fix erroring out of check_inode_names

The early exit logic in this function is a bit suboptimal -- we don't
need to close the @fd if we haven't even opened it, and since all errors
are fatal, we don't need to bump the progress counter.  The logic in
this function is about to get more involved due to the addition of the
directory tree structure checker, so clean up these warts.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
scrub/phase5.c