]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commit
iio: adc: ad4062: Replace IRQF_ONESHOT with IRQF_NO_THREAD
authorFelix Gu <ustc.gu@gmail.com>
Mon, 23 Feb 2026 06:45:13 +0000 (14:45 +0800)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 1 Mar 2026 11:20:11 +0000 (11:20 +0000)
commit20c2a46da4c65ac9c84f2876e2369a260b50e95b
treea294129ccbb014bdbe1b2834e3b515fdfeb836ef
parentd14116f6529fa085b1a1b1f224dc9604e4d2a29c
iio: adc: ad4062: Replace IRQF_ONESHOT with IRQF_NO_THREAD

In ad4062_request_irq(), when request irq for "gp1", the code uses
IRQF_ONESHOT flag, which is not appropriate for a primary handler
that does not have a secondary threaded handler.

And since commit aef30c8d569c ("genirq: Warn about using IRQF_ONESHOT
without a threaded handler"), the IRQ core checks IRQF_ONESHOT flag
in IRQ request and gives a warning if there is no threaded handler.

Since there is no threaded handler, replace devm_request_threaded_irq
with devm_request_irq, and replace IRQF_ONESHOT with IRQF_NO_THREAD.

Also remove an extraneous semicolon at the end of
ad4062_write_raw_dispatch().

Found by code review, compile pass.

Fixes: d5284402d28f ("iio: adc: Add support for ad4062")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/ad4062.c