git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit

]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit

author	Ilya Dryomov <idryomov@gmail.com>
	Sat, 19 Feb 2022 15:43:04 +0000 (16:43 +0100)
committer	Ilya Dryomov <idryomov@gmail.com>
	Mon, 21 Feb 2022 13:57:44 +0000 (14:57 +0100)
commit	219c500977bbfbcfe4ccd24beb294edbe0562d35
tree	6f707acfab1b2f931401fbe429b634fb325c262b	tree \| snapshot
parent	cee3cae9b2d1ea14db0ffaf3984486d278ff8871	commit \| diff

rbd-mirror: straighten ImageReplayer::stop() a bit

- don't default on_finish parameter
- m_restart_requested is set in ImageReplayer::restart() which is the
only restart=true call site, so setting m_restart_requested here is
redundant
- is_stopped_() can't be true in is_running_() branch
- on_finish->complete(0) in the end is unreachable

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

src/test/rbd_mirror/test_mock_ImageReplayer.cc		diff \| blob \| history
src/tools/rbd_mirror/ImageReplayer.cc		diff \| blob \| history
src/tools/rbd_mirror/ImageReplayer.h		diff \| blob \| history

Unnamed repository; edit this file 'description' to name the repository.

RSS Atom