]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
common,mds,mgr,mon,osd: store event only if it's added
authorKefu Chai <kchai@redhat.com>
Thu, 13 Jul 2017 06:49:48 +0000 (14:49 +0800)
committerKefu Chai <kchai@redhat.com>
Sun, 20 Aug 2017 06:14:30 +0000 (14:14 +0800)
commit2449b3a5c365987746ada095fde30e3dc63ee0c7
treeebcb6debbe5ec5cb05778e0f52d1d3ae54672b69
parente407049a6a9cb588f27ab270948c404159aa2205
common,mds,mgr,mon,osd: store event only if it's added

otherwise
* we will try to cancel it even it's never been added
* we will keep a dangling pointer around. which is, well,
  scaring.
* static analyzer will yell at us:
  Memory - illegal accesses  (USE_AFTER_FREE)

Signed-off-by: Kefu Chai <kchai@redhat.com>
28 files changed:
src/client/Client.cc
src/client/Client.h
src/common/Timer.cc
src/common/Timer.h
src/journal/JournalMetadata.cc
src/journal/ObjectPlayer.cc
src/journal/ObjectPlayer.h
src/journal/ObjectRecorder.cc
src/journal/ObjectRecorder.h
src/mds/Beacon.cc
src/mds/Beacon.h
src/mds/MDSDaemon.cc
src/mds/MDSDaemon.h
src/mgr/MgrClient.cc
src/mon/Elector.cc
src/mon/MgrMonitor.cc
src/mon/Monitor.cc
src/mon/Paxos.cc
src/mon/PaxosService.cc
src/osd/PrimaryLogPG.h
src/osd/Watch.cc
src/test/perf_local.cc
src/test/rbd_mirror/mock/MockSafeTimer.h
src/test/rbd_mirror/test_mock_ImageReplayer.cc
src/test/rbd_mirror/test_mock_InstanceReplayer.cc
src/test/rbd_mirror/test_mock_PoolWatcher.cc
src/tools/rbd_mirror/PoolWatcher.cc
src/tools/rbd_mirror/image_sync/ImageCopyRequest.cc