]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Fix NotifyOnFlushCompleted() for atomic flush (#8585)
authorYanqin Jin <yanqin@fb.com>
Tue, 3 Aug 2021 20:30:05 +0000 (13:30 -0700)
committerLevi Tamasi <ltamasi@fb.com>
Wed, 4 Aug 2021 18:24:41 +0000 (11:24 -0700)
commit2511b42c7eaccefee4e79f01a9f1bc3c66cfabbc
treecc1495850a1566c688e273d3e59e75c210d47be7
parent1920121cefe6311e3011e8776e2b427dae0c8304
Fix NotifyOnFlushCompleted() for atomic flush (#8585)

Summary:
PR https://github.com/facebook/rocksdb/issues/5908 added `flush_jobs_info_` to `FlushJob` to make sure
`OnFlushCompleted()` is called after committing flush results to
MANIFEST. However, `flush_jobs_info_` is not updated in atomic
flush, causing `NotifyOnFlushCompleted()` to skip `OnFlushCompleted()`.

This PR fixes this, in a similar way to https://github.com/facebook/rocksdb/issues/5908 that handles regular flush.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/8585

Test Plan: make check

Reviewed By: jay-zhuang

Differential Revision: D29913720

Pulled By: riversand963

fbshipit-source-id: 4ff023c98372fa2c93188d4a5c8a4e9ffa0f4dda
db/db_impl/db_impl_compaction_flush.cc
db/flush_job_test.cc
db/listener_test.cc
db/memtable_list.cc
db/memtable_list.h
db/memtable_list_test.cc