]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commit
serial: caif: hold tty->link reference in ldisc_open and ser_release
authorShuangpeng Bai <shuangpeng.kernel@gmail.com>
Fri, 6 Mar 2026 03:40:06 +0000 (22:40 -0500)
committerJakub Kicinski <kuba@kernel.org>
Tue, 10 Mar 2026 01:47:55 +0000 (18:47 -0700)
commit288598d80a068a0e9281de35bcb4ce495f189e2a
tree352d14c91fa6a3b19c125390932af6cbb20469a0
parent87d126852158467ab87d5cbc36ccfd3f15464a6c
serial: caif: hold tty->link reference in ldisc_open and ser_release

A reproducer triggers a KASAN slab-use-after-free in pty_write_room()
when caif_serial's TX path calls tty_write_room(). The faulting access
is on tty->link->port.

Hold an extra kref on tty->link for the lifetime of the caif_serial line
discipline: get it in ldisc_open() and drop it in ser_release(), and
also drop it on the ldisc_open() error path.

With this change applied, the reproducer no longer triggers the UAF in
my testing.

Link: https://gist.github.com/shuangpengbai/c898debad6bdf170a84be7e6b3d8707f
Link: https://lore.kernel.org/netdev/20260301220525.1546355-1-shuangpeng.kernel@gmail.com
Fixes: e31d5a05948e ("caif: tty's are kref objects so take a reference")
Signed-off-by: Shuangpeng Bai <shuangpeng.kernel@gmail.com>
Reviewed-by: Jiayuan Chen <jiayuan.chen@linux.dev>
Link: https://patch.msgid.link/20260306034006.3395740-1-shuangpeng.kernel@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/caif/caif_serial.c