]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ansible.git/commit
iscsi: don't set default value for trusted_ip_list
authorGuillaume Abrioux <gabrioux@redhat.com>
Wed, 18 Aug 2021 11:23:44 +0000 (13:23 +0200)
committerDimitri Savineau <savineau.dimitri@gmail.com>
Thu, 19 Aug 2021 16:06:42 +0000 (12:06 -0400)
commit299c81c58bd8ea7936b86767d1ddda7b38125d45
tree9541dcd480ea1ca15b802fbf1838ec4e9b545c71
parente3e849378ec416c61caa7d6c87b13f713c7b9a48
iscsi: don't set default value for trusted_ip_list

It restricts access to the iSCSI API.
It can be left empty if the API isn't going to be access from outside the
gateway node

Even though this seems to be a limited use case, it's better to leave it
empty by default than having a meaningless default value.

We could make this variable mandatory but that would be a breaking
change. Let's just add a logic in the template in order to set this
variable in the configuration file only if it was specified by users.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1994930
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
Co-authored-by: Dimitri Savineau <dsavinea@redhat.com>
(cherry picked from commit 6802b8dddd7f8d1f1c47f4eb3b7dd6a6a48820dc)
group_vars/iscsigws.yml.sample
roles/ceph-iscsi-gw/defaults/main.yml
roles/ceph-iscsi-gw/tasks/common.yml
roles/ceph-iscsi-gw/templates/iscsi-gateway.cfg.j2