]> git.apps.os.sepia.ceph.com Git - ceph-client.git/commit
scsi: elx: libefc: Fix potential use after free in efc_nport_vport_del()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 15 Aug 2024 11:29:05 +0000 (14:29 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 23 Aug 2024 01:08:44 +0000 (21:08 -0400)
commit2e4b02fad094976763af08fec2c620f4f8edd9ae
treed976acbcc532fcae5a85ca2c762cd419301fab99
parent89835a58f5f54d52537709f2513fb91024e2d069
scsi: elx: libefc: Fix potential use after free in efc_nport_vport_del()

The kref_put() function will call nport->release if the refcount drops to
zero.  The nport->release release function is _efc_nport_free() which frees
"nport".  But then we dereference "nport" on the next line which is a use
after free.  Re-order these lines to avoid the use after free.

Fixes: fcd427303eb9 ("scsi: elx: libefc: SLI and FC PORT state machine interfaces")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/b666ab26-6581-4213-9a3d-32a9147f0399@stanley.mountain
Reviewed-by: Daniel Wagner <dwagner@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/elx/libefc/efc_nport.c