]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
qa/cephfs: don't inherit CephFSTestCase in CapTester
authorRishabh Dave <ridave@redhat.com>
Thu, 13 Apr 2023 19:08:33 +0000 (00:38 +0530)
committerRishabh Dave <ridave@redhat.com>
Thu, 4 Apr 2024 11:39:42 +0000 (17:09 +0530)
commit2f8562119abc1872e2c98d2aecd2322e2c563694
treef35471a70cc5a40f35c9909161f732eaecf8adc8
parent502fbf825fba583c9927234835a556fd7291a283
qa/cephfs: don't inherit CephFSTestCase in CapTester

Inheritting CephFSTestCase in CapTester just for methods assertEqual()
and assertIn() from class unittest.TestCase is odd and heavy-weight.
Don't inherit CephFSTestCase and use simple assert instead.

Reference: https://github.com/ceph/ceph/pull/50882#discussion_r1160611549.

To avoid code duplication, a couple of similar methods have been added
instead.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit e8bdf94b814eb09f859e6d1e31d53e826a7bffcc)

Conflicts:
  qa/tasks/cephfs/caps_helper.py
  - Conflict occured because code on Reef branch changed due to merging of
    commit 59c9104c54d6.
qa/tasks/cephfs/caps_helper.py