]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Fix a bug for surfacing write unix time (#13057)
authorYu Zhang <yuzhangyu@fb.com>
Tue, 8 Oct 2024 18:31:51 +0000 (11:31 -0700)
committerYu Zhang <yuzhangyu@fb.com>
Tue, 8 Oct 2024 18:41:38 +0000 (11:41 -0700)
commit2fef013616ac8e474d19f6b0815155a37ae9350f
treea38994bdb0ddf4ff80d4599f1902648dc3992148
parenta24567271031a16115c0ceb4abee03acd9831787
Fix a bug for surfacing write unix time (#13057)

Summary:
The write unix time from non L0 files are not surfaced properly because the level's wrapper iterator doesn't have a `write_unix_time` implementation that delegates to the corresponding file. The unit test didn't catch this because it incorrectly destroy the old db and reopen to check write time, instead of just reopen and check. This fix also include a change to support ldb's scan command to get write time for easier debugging.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/13057

Test Plan: Updated unit tests

Reviewed By: pdillinger

Differential Revision: D64015107

Pulled By: jowlyzhang

fbshipit-source-id: 244474f78a034f80c9235eea2aa8a0f4e54dff59
db/compaction/tiered_compaction_test.cc
db/forward_iterator.cc
db/version_set.cc
include/rocksdb/utilities/ldb_cmd.h
table/iterator.cc
tools/ldb_cmd.cc
tools/ldb_cmd_impl.h