]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Report corrupted keys during compaction (#7124)
authorYanqin Jin <yanqin@fb.com>
Wed, 15 Jul 2020 00:16:18 +0000 (17:16 -0700)
committerAndrew Kryczka <andrewkr@fb.com>
Thu, 16 Jul 2020 00:51:08 +0000 (17:51 -0700)
commit30bfa2a44e6511c0a0a9bcfed04b45f986f5038d
tree158adac5e541421cb75607fc9d3e59b60d6e53e5
parent3e1eb99ab7e9a5f4dfb65a9d7180924b409ba12c
Report corrupted keys during compaction (#7124)

Summary:
Currently, RocksDB lets compaction to go through even in case of
corrupted keys, the number of which is reported in CompactionJobStats.
However, RocksDB does not check this value. We should let compaction run
in a stricter mode.

Temporarily disable two tests that allow corrupted keys in compaction.
With this PR, the two tests will assert(false) and terminate. Still need
to investigate what is the recommended google-test way of doing it.
Death test (EXPECT_DEATH) in gtest has warnings now.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/7124

Test Plan: make check

Reviewed By: ajkr

Differential Revision: D22530722

Pulled By: riversand963

fbshipit-source-id: 6a5a6a992028c6d4f92cb74693c92db462ae4ad6
HISTORY.md
db/compaction/compaction_iterator.cc
db/compaction/compaction_job.cc
db/compaction/compaction_job_test.cc