]> git.apps.os.sepia.ceph.com Git - xfstests-dev.git/commit
generic/699: fix failure with MOUNT_OPTIONS
authorAmir Goldstein <amir73il@gmail.com>
Tue, 3 Jun 2025 10:07:45 +0000 (12:07 +0200)
committerZorro Lang <zlang@kernel.org>
Fri, 6 Jun 2025 11:45:46 +0000 (19:45 +0800)
commit3563fda0140f8512e15578eb975da15d0fa04052
tree6a5af470f2ccf86d1e2e55f435682ef2a56f32a4
parent3d339199525f1a74a08210701c117dc2731286d6
generic/699: fix failure with MOUNT_OPTIONS

generic/699 uses overalyfs helper _overlay_mount_dirs, which is meant to
be used by overlayfs tests, where MOUNT_OPTIONS refer to overalyfs mount
options.

Using this helper from a generic test when FSTYP is not overlay is
causing undesired results. For example, when MOUNT_OPTIONS is defined
and includes a mount option not supported by overalyfs (e.g. 'acl'),
the test is notrun because of:

mount: /vdc/ovl-merge: fsconfig() failed: overlay: Unknown parameter 'acl'.

There is no other generic test that includes the common/overlay helpers
and uses them, so remove this practice from generic/699 as well.

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Reviewed-by: Zorro Lang <zlang@redhat.com>
Signed-off-by: Zorro Lang <zlang@kernel.org>
tests/generic/699