]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commit
libceph: Fix potential out-of-bounds access in osdmap_decode()
authorRaphael Zimmer <raphael.zimmer@tu-ilmenau.de>
Tue, 5 May 2026 09:08:12 +0000 (11:08 +0200)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 11 May 2026 18:53:53 +0000 (20:53 +0200)
commit35d0ed82d03e5ee77ea4f31f20e29562a7721649
tree137e2c19df10d39eddc65a8e05b2612244f89153
parent544576f0f05c4a759806acddfaaeb686f14fb4b0
libceph: Fix potential out-of-bounds access in osdmap_decode()

When decoding osd_state and osd_weight from an incoming osdmap in
osdmap_decode(), both are decoded for each osd, i.e., map->max_osd
times. The ceph_decode_need() check only accounts for
sizeof(*map->osd_weight) once. This can potentially result in an
out-of-bounds memory access if the incoming message is corrupted such
that the max_osd value exceeds the actual content of the osdmap message.

This patch fixes the issue by changing the corresponding part in the
ceph_decode_need() check to account for
map->max_osd*sizeof(*map->osd_weight).

Cc: stable@vger.kernel.org
Fixes: dcbc919a5dc8 ("libceph: switch osdmap decoding to use ceph_decode_entity_addr")
Signed-off-by: Raphael Zimmer <raphael.zimmer@tu-ilmenau.de>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
net/ceph/osdmap.c