]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
test/objectstore: set "threadsafe" flag for ASSERT_DEATH tests
authorKefu Chai <kchai@redhat.com>
Tue, 24 Mar 2020 12:12:36 +0000 (20:12 +0800)
committerKefu Chai <kchai@redhat.com>
Tue, 24 Mar 2020 12:16:10 +0000 (20:16 +0800)
commit373f587f0fceaa4aab994172a98459b670fcf79b
tree3bf57ad81b1bca6cddc6a1bf65d1cc66cb86d53f
parent3f5a801d972694750c8fce7cc8b5136a37c82b43
test/objectstore: set "threadsafe" flag for ASSERT_DEATH tests

we are seeing failures like

192/192 Test #144: unittest_chain_xattr ....................***Timeout 3600.01 sec
[==========] Running 5 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 5 tests from chain_xattr
[ RUN      ] chain_xattr.get_and_set

[WARNING] /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest-death-test.cc:1122:: Death tests use fork(), which is unsafe particularly in a threaded context.
For this test, Google Test detected 3 threads. See https://github.com/google/googletest/blob/master/googletest/docs/advanced.md#death-tests-and-threads for more explanation and suggested solutions,
especially if this is the last message you see before your test times out.

so in this change, the "threadsafe" death test style is used for
testing the expected assertion failures.

see also
https://github.com/google/googletest/blob/master/googletest/docs/advanced.md#death-test-styles

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/test/objectstore/chain_xattr.cc