]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Fix heap use after free error on retry after checksum mismatch (#12464)
authoranand76 <anand1976@users.noreply.github.com>
Thu, 21 Mar 2024 23:19:09 +0000 (16:19 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Thu, 21 Mar 2024 23:19:09 +0000 (16:19 -0700)
commit3b736c4aa3b997cc8ca05fda0f004f6e414a8812
treefcbb6d84ee9a698ade0eae7bd7c4f606463c591d
parent088dc7283bebb53eecdc21a0744931b3c88460f3
Fix heap use after free error on retry after checksum mismatch (#12464)

Summary:
Fix the heap use after free bug caused by freeing the file system IO buffer in `BlockFetcher::ReadBlock()` instead of the caller.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/12464

Test Plan: Update the `DBIOCorruptionTest` tests

Reviewed By: akankshamahajan15

Differential Revision: D55206920

Pulled By: anand1976

fbshipit-source-id: fd6b608a61cd229b20c1e5f348ff3cc92328de0f
db/db_io_failure_test.cc
include/rocksdb/file_system.h
table/block_fetcher.cc
table/block_fetcher.h