]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Show sandcastle URL in phabricator
authorIslam AbdelRahman <tec@fb.com>
Tue, 20 Dec 2016 18:54:38 +0000 (10:54 -0800)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Tue, 20 Dec 2016 19:09:12 +0000 (11:09 -0800)
commit3cd9ed1c310eb962f999a06bcbbfb2979e941aa1
tree7487334b1848220cde70f7b5fdbb4f6948c38074
parent50e305de987c59b6d0459cd3d75f55912f781654
Show sandcastle URL in phabricator

Summary:
We are passing a string as diff_id which make conduit call fail

```
$ echo '{"diff_id": "20982117", "name":"click here for sandcastle tests for D20982117", "link":"https://our.intern.facebook.com/intern/sandcastle/1984718793/"}' | arc call-conduit differential.updateunitresults
{"error":"ERR-CONDUIT-CORE","errorMessage":"ERR-CONDUIT-CORE: Argument 1 passed to EntDiffPropertiesUpdateMutationBuilder::setDiffNumber() must be an instance of int, string given","response":null}
```

fix it by removing double quotes
Closes https://github.com/facebook/rocksdb/pull/1700

Differential Revision: D4350227

Pulled By: IslamAbdelRahman

fbshipit-source-id: b4504af
arcanist_util/config/RocksDBCommonHelper.php