]> git.apps.os.sepia.ceph.com Git - ceph-client.git/commit
tracing: Fix tracing_marker may trigger page fault during preempt_disable
authorLuo Gengkun <luogengkun@huaweicloud.com>
Tue, 19 Aug 2025 10:51:52 +0000 (10:51 +0000)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Tue, 2 Sep 2025 16:02:42 +0000 (12:02 -0400)
commit3d62ab32df065e4a7797204a918f6489ddb8a237
tree813042c6413e7d76df03c5758a4e58deb263c3a6
parent81ac63321eb936b1a1f7045b37674661f8ffb4a5
tracing: Fix tracing_marker may trigger page fault during preempt_disable

Both tracing_mark_write and tracing_mark_raw_write call
__copy_from_user_inatomic during preempt_disable. But in some case,
__copy_from_user_inatomic may trigger page fault, and will call schedule()
subtly. And if a task is migrated to other cpu, the following warning will
be trigger:
        if (RB_WARN_ON(cpu_buffer,
                       !local_read(&cpu_buffer->committing)))

An example can illustrate this issue:

process flow CPU
---------------------------------------------------------------------

tracing_mark_raw_write(): cpu:0
   ...
   ring_buffer_lock_reserve(): cpu:0
      ...
      cpu = raw_smp_processor_id() cpu:0
      cpu_buffer = buffer->buffers[cpu] cpu:0
      ...
   ...
   __copy_from_user_inatomic(): cpu:0
      ...
      # page fault
      do_mem_abort(): cpu:0
         ...
         # Call schedule
         schedule() cpu:0
 ...
   # the task schedule to cpu1
   __buffer_unlock_commit(): cpu:1
      ...
      ring_buffer_unlock_commit(): cpu:1
 ...
 cpu = raw_smp_processor_id() cpu:1
 cpu_buffer = buffer->buffers[cpu] cpu:1

As shown above, the process will acquire cpuid twice and the return values
are not the same.

To fix this problem using copy_from_user_nofault instead of
__copy_from_user_inatomic, as the former performs 'access_ok' before
copying.

Link: https://lore.kernel.org/20250819105152.2766363-1-luogengkun@huaweicloud.com
Fixes: 656c7f0d2d2b ("tracing: Replace kmap with copy_from_user() in trace_marker writing")
Signed-off-by: Luo Gengkun <luogengkun@huaweicloud.com>
Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace.c