]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
crimson/.../snaptrim_event: remove remaining SnapTrimEvent pipeline stages
authorSamuel Just <sjust@redhat.com>
Tue, 28 May 2024 20:37:56 +0000 (13:37 -0700)
committerSamuel Just <sjust@redhat.com>
Thu, 13 Jun 2024 18:44:55 +0000 (11:44 -0700)
commit403a0c2c9c67d31814f44f9ba01ace71c0e93976
tree9b6f63afccc81f6b61146106e17d1a05ea8546c5
parentd4fc96b047b86ed7352c215e751f13f50de74a4a
crimson/.../snaptrim_event: remove remaining SnapTrimEvent pipeline stages

SnapTrimEvent doesn't actually do or block on GetOBC or Process --
remove those stages entirely.  Entering Process, in particular, causes
problems unless we immediately leave it as SnapTrimObjSubEvent needs to
enter and leave it to complete.  Entering one of the stages removed in
a prior commit had a side effect of exiting Process -- without that
exit SnapTrimEvent and SnapTrimObjSubEvent mutually block preventing
snap trim or client io from making progress.

This leaves no actual pipeline stages on SnapTrimEvent, which makes
sense as only SnapTrimObjSubEvent actually does IO.

Signed-off-by: Samuel Just <sjust@redhat.com>
src/crimson/osd/osd_operations/snaptrim_event.cc
src/crimson/osd/osd_operations/snaptrim_event.h