]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Avoid updating option if there's no value updated (#8518)
authorJay Zhuang <zjay@fb.com>
Wed, 21 Jul 2021 20:44:39 +0000 (13:44 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Wed, 21 Jul 2021 20:45:59 +0000 (13:45 -0700)
commit42eaa45c1bfcc33935d3cfdc4694955e2f1f3265
treea99405a4a6c820735981a71667f6cf4f9ee96deb
parent6b4cdacf41fa3565786fc2376210ba59c289e22d
Avoid updating option if there's no value updated (#8518)

Summary:
Try avoid expensive updating options operation if
`SetDBOptions()` does not change any option value.
Skip updating is not guaranteed, for example, changing `bytes_per_sync`
to `0` may still trigger updating, as the value could be sanitized.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/8518

Test Plan: added unittest

Reviewed By: riversand963

Differential Revision: D29672639

Pulled By: jay-zhuang

fbshipit-source-id: b7931de62ceea6f1bdff0d1209adf1197d3ed1f4
HISTORY.md
db/db_impl/db_impl.cc
db/db_options_test.cc
options/db_options.cc
options/db_options.h