]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
osd: replace deprecated atomic_store with std::atomic<shared_ptr>
authorKefu Chai <tchaikov@gmail.com>
Sat, 29 Mar 2025 13:29:43 +0000 (21:29 +0800)
committerKefu Chai <tchaikov@gmail.com>
Sat, 29 Mar 2025 13:32:17 +0000 (21:32 +0800)
commit43d8ca484de84029323321f05662c27af35be356
tree5a3b2347441bfa067f3258873f8dbda4d4381d5d
parent2694580314dc81e1c3f9a1ccd7107a13b949bb59
osd: replace deprecated atomic_store with std::atomic<shared_ptr>

Update shared pointer atomic operations to use C++20's
`std::atomic<std::shared_ptr>` instead of the deprecated `atomic_store`
functions. This change addresses deprecation warnings from GCC-15's
libstdc++ where atomic shared pointer operations outside the `std::atomic`
class are being phased out:

```
In file included from /home/kefu/dev/ceph/src/osd/Watch.cc:9:
/home/kefu/dev/ceph/src/osd/OSD.h:1675:10: warning: 'atomic_store<const OSDMap>' is deprecated: use 'std::atomic<std::shared_ptr<T>>' instead [-Wdeprecated-declarations]
 1675 |     std::atomic_store(&_osdmap, osdmap);
      |          ^
/usr/lib/gcc/x86_64-redhat-linux/15/../../../../include/c++/15/bits/shared_ptr_atomic.h:181:5: note: 'atomic_store<const OSDMap>' has been explicitly marked deprecated here
  181 |     _GLIBCXX20_DEPRECATED_SUGGEST("std::atomic<std::shared_ptr<T>>")
      |     ^
/usr/lib/gcc/x86_64-redhat-linux/15/../../../../include/c++/15/x86_64-redhat-linux/bits/c++config.h:2055:45: note: expanded from macro '_GLIBCXX20_DEPRECATED_SUGGEST'
 2055 | # define _GLIBCXX20_DEPRECATED_SUGGEST(ALT) _GLIBCXX_DEPRECATED_SUGGEST(ALT)
      |                                             ^
/usr/lib/gcc/x86_64-redhat-linux/15/../../../../include/c++/15/x86_64-redhat-linux/bits/c++config.h:2023:19: note: expanded from macro '_GLIBCXX_DEPRECATED_SUGGEST'
 2023 |   __attribute__ ((__deprecated__ ("use '" ALT "' instead")))
      |                   ^
In file included from /home/kefu/dev/ceph/src/osd/Watch.cc:9:
```

The implementation now uses the standard-compliant approach that's
recommended in the compiler warnings, while maintaining backward
compatibility with older compilers by conditionally selecting the
appropriate implementation.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
src/osd/OSD.h