]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Fix CompactionIterator flag for penultimate level output (#10967)
authorAndrew Kryczka <andrewkr@fb.com>
Tue, 22 Nov 2022 00:14:03 +0000 (16:14 -0800)
committerAndrew Kryczka <andrewkr@fb.com>
Thu, 24 Nov 2022 21:44:34 +0000 (13:44 -0800)
commit442b6b80487f2df8b19af242dce670ca816026e6
treeebd63bf91fdb4e729533fa1719da56f6773f47a0
parent8c069883131b4750cd70164a828db8611599e7dc
Fix CompactionIterator flag for penultimate level output (#10967)

Summary:
We were not resetting it in non-debug mode so it could be true once and then stay true for future keys where it should be false. This PR adds the reset logic.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/10967

Test Plan:
- built `db_bench` with DEBUG_LEVEL=0
- ran benchmark: `TEST_TMPDIR=/dev/shm/prefix ./db_bench -benchmarks=fillrandom -compaction_style=1 -preserve_internal_time_seconds=100 -preclude_last_level_data_seconds=10 -write_buffer_size=1048576 -target_file_size_base=1048576 -subcompactions=8 -duration=120`
- compared "output_to_penultimate_level: X bytes + last: Y bytes" lines in LOG output
  - Before this fix, Y was always zero
  - After this fix, Y gradually increased throughout the benchmark

Reviewed By: riversand963

Differential Revision: D41417726

Pulled By: ajkr

fbshipit-source-id: ace1e9a289e751a5b0c2fbaa8addd4eda5525329
HISTORY.md
db/compaction/compaction_iterator.cc