]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
librbd/migration/HttpClient: drop SslHttpSession::m_ssl_enabled
authorIlya Dryomov <idryomov@gmail.com>
Sat, 7 Dec 2024 12:52:41 +0000 (13:52 +0100)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 16 Dec 2024 08:51:23 +0000 (09:51 +0100)
commit4e1a80584c4626c9dc31bbb66eb0ae0149732cab
treefe436382d9e34a15cfa121f4aa310e7dcb7f1e0f
parent1e66e09e0f6c0cb3ed3de8ad3d98d61d7bf2a8d8
librbd/migration/HttpClient: drop SslHttpSession::m_ssl_enabled

The remaining callers of disconnect() call it only when m_ssl_enabled
is set to true (i.e. after the handshake is completed):

- shut_down(), in STATE_READY
- maybe_finalize_reset(), very shortly after transitioning out of
  STATE_READY as part of performing a reset
- advance_state(), on a transition to STATE_READY that is intercepted
  by a previously delayed shut down

m_ssl_enabled isn't used outside of disconnect() and on top of that
is never cleared.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 8566224e9406abca42925f8045077141c2724bed)
src/librbd/migration/HttpClient.cc