]> git-server-git.apps.pok.os.sepia.ceph.com Git - xfstests-dev.git/commit
common: disable infinite IO error retry for EIO shutdown tests
authorDarrick J. Wong <djwong@kernel.org>
Wed, 3 Aug 2022 04:22:35 +0000 (21:22 -0700)
committerZorro Lang <zlang@kernel.org>
Sun, 4 Sep 2022 13:44:05 +0000 (21:44 +0800)
commit4f929ebc59285d47f8a79c3d3f1e5f4ce316d6d0
tree7689a249249752c8cab879ca5eb4a5707e5fe7d4
parentf3c314574d011e4b8d5c6f605e0ec6fed9f3804c
common: disable infinite IO error retry for EIO shutdown tests

This patch fixes a rather hard to hit livelock in the tests that test
how xfs handles shutdown behavior when the device suddenly dies and
starts returing EIO all the time.  The livelock happens if the AIL is
stuck retrying failed metadata updates forever, the log itself is not
being written, and there is no more log grant space, which prevents the
frontend from shutting down the log due to EIO errors during
transactions.

While most users probably want the default retry-forever behavior
because EIO can be transient, the circumstances are different here.  The
tests are designed to flip the device back to working status only after
the unmount succeeds, so we know there's no point in the filesystem
retrying writes until after the unmount.

This fixes some of the periodic hangs in generic/019 and generic/475.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Zorro Lang <zlang@redhat.com>
Signed-off-by: Zorro Lang <zlang@kernel.org>
common/dmerror
common/fail_make_request
common/rc
common/xfs