]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Disable snapshot refresh feature when snap_refresh_nanos is 0 (#5724)
authorMaysam Yabandeh <myabandeh@fb.com>
Tue, 20 Aug 2019 18:38:15 +0000 (11:38 -0700)
committermyabandeh <myabandeh@fb.com>
Tue, 20 Aug 2019 20:20:32 +0000 (13:20 -0700)
commit4ff493bb38e951a59150601cd2ee3ff225df2862
treeccb4fe8b68d399c32ba74347a87114031fd59c79
parent0e7d927217cd1c473af2d61d62b44e3e1c5fa1c2
Disable snapshot refresh feature when snap_refresh_nanos is 0 (#5724)

Summary:
The comments of snap_refresh_nanos advertise that the snapshot refresh feature will be disabled when the option is set to 0. This contract is however not honored in the code: https://github.com/facebook/rocksdb/pull/5278
The patch fixes that and also adds an assert to ensure that the feature is not used when the option  is zero.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5724

Differential Revision: D16918185

Pulled By: maysamyabandeh

fbshipit-source-id: fec167287df7d85093e087fc39c0eb243e3bbd7e
HISTORY.md
db/compaction/compaction_iterator.h
db/compaction/compaction_job_test.cc
db/db_impl/db_impl_compaction_flush.cc
include/rocksdb/version.h