]> git.apps.os.sepia.ceph.com Git - ceph-client.git/commit
sched/deadline: Don't count nr_running for dl_server proxy tasks
authorYicong Yang <yangyicong@hisilicon.com>
Fri, 27 Jun 2025 03:54:20 +0000 (11:54 +0800)
committerPeter Zijlstra <peterz@infradead.org>
Tue, 26 Aug 2025 08:46:01 +0000 (10:46 +0200)
commit52d15521eb75f9b521744db675bee61025d2fa52
tree621231d5c8d3069e9601d6eb461abaeaed18fae5
parent421fc59cf58c64f898cafbbbbda0bc705837e7df
sched/deadline: Don't count nr_running for dl_server proxy tasks

On CPU offline the kernel stalled with below call trace:

  INFO: task kworker/0:1:11 blocked for more than 120 seconds.

cpuhp hold the cpu hotplug lock endless and stalled vmstat_shepherd.
This is because we count nr_running twice on cpuhp enqueuing and failed
the wait condition of cpuhp:

  enqueue_task_fair() // pick cpuhp from idle, rq->nr_running = 0
    dl_server_start()
      [...]
      add_nr_running() // rq->nr_running = 1
    add_nr_running() // rq->nr_running = 2
  [switch to cpuhp, waiting on balance_hotplug_wait()]
  rcuwait_wait_event(rq->nr_running == 1 && ...) // failed, rq->nr_running=2
    schedule() // wait again

It doesn't make sense to count the dl_server towards runnable tasks,
since it runs other tasks.

Fixes: 63ba8422f876 ("sched/deadline: Introduce deadline servers")
Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250627035420.37712-1-yangyicong@huawei.com
kernel/sched/deadline.c