]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
projects / ceph-ci.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: bbeefb2) | patch
pybind/mgr: apply_drivegroups should return Sequence[Completion]
authorKefu Chai <kchai@redhat.com>
Sun, 15 Mar 2020 03:52:54 +0000 (11:52 +0800)
committerKefu Chai <kchai@redhat.com>
Sun, 15 Mar 2020 04:39:46 +0000 (12:39 +0800)
commit54ec595811979ca9f5dd0424977e2a959a485ddd
treee5fdf914e0856235c1375c3804813d0169693deftree | snapshot
parentbbeefb2c10795aa2641c71dae537472bbe61874fcommit | diff
pybind/mgr: apply_drivegroups should return Sequence[Completion]

* change annotation of `orchestrator.Orchestrator.apply_drivegroups()` so it returns
  `Sequence[Completion]`
  see
  https://mypy.readthedocs.io/en/latest/generics.html#variance-of-generic-types
* to follow the interface defined by `orchestrator.Orchestrator`. change
  all its implementations. see `orchestrator/_interface.py`.

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/pybind/mgr/cephadm/module.py diff | blob | history
src/pybind/mgr/orchestrator/_interface.py diff | blob | history
src/pybind/mgr/test_orchestrator/module.py diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.