]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ci.git/commit
Annotated Striper.cc and PrimaryLogPG.cc
authorSuyash Dongre <suyashd999@gmail.com>
Thu, 13 Jun 2024 14:59:25 +0000 (20:29 +0530)
committerSuyash Dongre <suyashd999@gmail.com>
Tue, 18 Jun 2024 15:16:01 +0000 (20:46 +0530)
commit562e13df0e2a2679e53cd3aeed35cd40ff36f1c9
treec3fc718f001604935a2d84e98d75bb20ddd83a1c
parent8c4f910f646947fd5a6025aee76003c4d279bb82
Annotated Striper.cc and PrimaryLogPG.cc

1. src/osd/PrimaryLogPG.cc:

It's safe to use  clear() on operand that has been moved.
reference: https://github.com/ceph/ceph/pull/48839/files

2. src/osdc/Striper.cc:

This is a false-positive because in the loop the bufferlist is only being moved when the size of the buffer_extents is equal to 1 otherwise it will not move
reference: https://github.com/ceph/ceph/blob/e879ce83c084f1a96e5dd0ab2b57bf909cfa423d/src/osdc/Striper.cc#L411-L415

Signed-off-by: Suyash Dongre <suyashd999@gmail.com>
src/osd/PrimaryLogPG.cc
src/osdc/Striper.cc