]> git-server-git.apps.pok.os.sepia.ceph.com Git - xfstests-dev.git/commit
fuzzy: skip online scrub and health checks if not supported v2023.05.28
authorAnthony Iliopoulos <ailiop@suse.com>
Mon, 22 May 2023 21:27:12 +0000 (23:27 +0200)
committerZorro Lang <zlang@kernel.org>
Sat, 27 May 2023 18:14:03 +0000 (02:14 +0800)
commit596db5ee91823292e64c842c64010571a3d6ca74
treecd6530187c3bec2d63cc156df93cf8f7cbd03179
parent6dfe7b6b9033daf6b5dab95ad50531966bf41cbf
fuzzy: skip online scrub and health checks if not supported

Commit a27e6e6f4c18 introduced xfs health checking on no-repair fuzz,
which in turn requires scrub to be run before that. The health checks
are done only if scrub returns with an error (which is expected as an
indication that fuzzed metadata errors were picked up), but the code
does not discern between xfs_scrub returning an error because of
uncorrected metadata vs failing because the kernel does not support
scrub at all.

This causes all tests that do fuzzing with no-repair strategy to fail on
kernels compiled without online scrub support (CONFIG_XFS_ONLINE_SCRUB).

Skip scrub and health checks altogether, if the kernel does not support
it, since the tests are still valuable.

Fixes: a27e6e6f4c18 ("common: check xfs health after doing an online scrub")
Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
Reviewed-by: Zorro Lang <zlang@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Zorro Lang <zlang@kernel.org>
common/fuzzy