]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commit
libceph: Fix unnecessarily high ceph_decode_need() for uniform bucket
authorRaphael Zimmer <raphael.zimmer@tu-ilmenau.de>
Fri, 24 Apr 2026 13:37:37 +0000 (15:37 +0200)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 11 May 2026 08:39:22 +0000 (10:39 +0200)
commit596f91294b351866956808b1ecb8dfae15382a6d
tree6905a0900c95e22788cea2e7ed72e0cb845d11b8
parent4c79fc2d598694bda845b46229c9d48b65042970
libceph: Fix unnecessarily high ceph_decode_need() for uniform bucket

In crush_decode_uniform_bucket(), the item_weight field of the bucket
is set. This is a single field of type u32 since the uniform bucket uses
the same weight for all items. The value in ceph_decode_need() is set to
(1+b->h.size) * sizeof(u32), which is higher than actually needed.

This patch removes the call to ceph_decode_need() with the unnecessarily
high value and switches the subsequent operation from ceph_decode_32()
to ceph_decode_32_safe(), which already includes the correct bounds
check.

Signed-off-by: Raphael Zimmer <raphael.zimmer@tu-ilmenau.de>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
net/ceph/osdmap.c