]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
crimson/os/alienstore/CmakeLists: Drop WITH_SEASTAR/ALIEN
authorMatan Breizman <mbreizma@redhat.com>
Wed, 5 Feb 2025 10:41:16 +0000 (10:41 +0000)
committerMatan Breizman <mbreizma@redhat.com>
Tue, 11 Mar 2025 12:40:42 +0000 (12:40 +0000)
commit5bb1d9e1d581ea030f59a7e1555e3d774a034e12
tree23e002175faa99a03c3584ae8be9ae49867b9555
parentfacd084b6946bc971584516880aa5874f4876832
crimson/os/alienstore/CmakeLists: Drop WITH_SEASTAR/ALIEN

Removing WITH_SEASTAR/WITH_ALIEN will allow us to remove
WITH_ALIEN all together as now "alien" targets
are not defined WITH_SEASTAR.
Mere WITH_SEASTAR is enough to differentiate between "alien"
targets to ones used by Crimson.

Note: The cmake subdirectory of "crimson" will pull WITH_SEASTAR
to crimson-alienstore. That is why "crimson" is replaced by "seastar".
Ideally, we would not need to use "seastar" as well but the pure
alien sources (e.g alien_*.cc) must use seastar's concepts.

This "workaround" results in an crimson-alienstore to not be defined
WITH_SEASTAR even though it uses seastar. While this is not trivial,
it will help with removing WITH_ALIEN which makes Crimson's cmake
harder to understand. Moreover, WITH_SEASTAR trully represents a
Crimson target - and as crimson-alienstore is not trully Crimson,
his "workaround" seems to fit best.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
src/crimson/os/alienstore/CMakeLists.txt